Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging changes #430

Merged
merged 99 commits into from
Mar 28, 2023
Merged

Merging changes #430

merged 99 commits into from
Mar 28, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Mar 14, 2023

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

#430
hms-dbmi-cellenics/ui#828
hms-dbmi-cellenics/pipeline#300
hms-dbmi-cellenics/worker#300

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #430 (dbc8dc9) into master (ebefb8a) will increase coverage by 0.28%.
The diff coverage is 96.18%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   90.45%   90.73%   +0.28%     
==========================================
  Files         148      155       +7     
  Lines        3309     3401      +92     
  Branches      370      377       +7     
==========================================
+ Hits         2993     3086      +93     
+ Misses        299      298       -1     
  Partials       17       17              
Impacted Files Coverage Δ
src/api.v2/events/validateAndSubmitWork.js 100.00% <ø> (ø)
...uct/constructors/paramsGetters/getGeneralParams.js 88.88% <ø> (ø)
...e/pipelineConstruct/constructors/submitBatchJob.js 100.00% <ø> (ø)
src/api.v2/helpers/s3/getS3Client.js 100.00% <ø> (ø)
src/api.v2/model/Experiment.js 90.81% <ø> (ø)
src/api.v2/model/ExperimentExecution.js 71.42% <ø> (ø)
src/config/default-config.js 64.40% <ø> (ø)
src/config/test-config.js 100.00% <ø> (ø)
.../plotConfigInvalidation/invalidatePlotsForEvent.js 100.00% <ø> (ø)
tests/api.v2/mocks/data/invalidationResults.js 100.00% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cosa65 and others added 7 commits March 22, 2023 11:11
Implement retry mechanism for S3 put_object calls when they fail with 5xx error
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
@alexvpickering alexvpickering merged commit 75c6819 into master Mar 28, 2023
@alexvpickering alexvpickering deleted the biomage-changes-3 branch March 28, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants