Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Both the pipeline and the default value set in data ingest expect maxFraction to be a fraction while the UI should display a percentage instead.
As the ticket says, the permanent fix would entail modifying the
maxFraction
processingConfig property to bemaxPercentage
in all the relevant places, which includes: data ingest (default value), pipeline, api (validation), ui (because it now accounts for this disparity) and also all the processingConfigs in experiments in dynamodb.Performing this right now is not ideal since we are now using many experiments across both staging and production, so we have decided to create a ticket to implement the permanent solution when we are able to create databases migrations automatically.
The ticket for this is here: https://biomage.atlassian.net/browse/BIOMAGE-797
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-776
Link to staging deployment URL
https://ui-martinfosco-ui201.scp-staging.biomage.net/
Links to any Pull Requests related to this
Anything else the reviewers should know about the changes here
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing
To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?
Approvers
Just before merging:
unstage
script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to stagingOptional