Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][AZURE] Flag delete_os_disk_on_termination has no effect when removing cluster #3065

Closed
8 of 18 tasks
cicharka opened this issue Apr 7, 2022 · 1 comment · Fixed by #3070
Closed
8 of 18 tasks

Comments

@cicharka
Copy link
Contributor

cicharka commented Apr 7, 2022

Describe the bug
In configuration of virtual-machines there is flag delete_on_termination set to false, but it doesn't have effect during cluster removal (epicli delete) and all of the OS disks are removed anyway. Also, when using similar flag for data disk (delete_data_disks_on_termination), it has no effect.

How to reproduce

  1. execute epicli apply ...
  2. execute epicli delete ... on that build

Expected behavior
When setting delete_on_termination flag to false (which is default) OS disks should not be removed during epicli delete.

Config files
Any config

Environment

  • Cloud provider: Azure
  • OS: Ubuntu 20.04.3 LTS

epicli version: [epicli --version]

  • 2.0.0dev
  • all of the previous versions that use that flag

Additional context
On AWS this flag can preserve disks from being removed when removing cluster with epicli delete.
According to this comment it is because deletion of whole Resource Group.


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
@cicharka
Copy link
Contributor Author

cicharka commented Apr 7, 2022

Todo:

  • extend warning prompted during epicli delete
  • remove delete_on_termination flag from epi schema and terraform vm definitions for Azure
  • update documentation (inform about behavior during removal)

@cicharka cicharka self-assigned this Apr 7, 2022
This was referenced Apr 8, 2022
cicharka added a commit that referenced this issue Apr 8, 2022
* azure: remove delete_on_termination flag
* enhance docs
* improve delete command
@cicharka cicharka reopened this Apr 8, 2022
@seriva seriva closed this as completed Apr 14, 2022
seriva added a commit that referenced this issue May 11, 2022
* Added #2976

* Fixed #2992

* Fixed #2876

* Fixed #3004

* Fix #2934

* Added #1076

* Removed un-used certificate stuff

* Properly fixed #2876

* Add EOF EL

* Update CHANGELOG-1.0.md

Co-authored-by: Rafal Zeidler <[email protected]>

* azure: fix for #3065

* comment more entries for #2934

* Escalate permissions for ip command (#2952)

* Add documentation for custom terraform scripts

* Remove one more duplicate entry in image-registry defaults

Co-authored-by: Rafal Zeidler <[email protected]>
Co-authored-by: cicharka <[email protected]>
Co-authored-by: Irek Głownia <[email protected]>
Co-authored-by: przemyslavic <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants