Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Allow for custom Terraform scripts #2976

Closed
9 of 20 tasks
seriva opened this issue Feb 11, 2022 · 1 comment
Closed
9 of 20 tasks

[FEATURE REQUEST] Allow for custom Terraform scripts #2976

seriva opened this issue Feb 11, 2022 · 1 comment
Assignees
@seriva @przemyslavic
Labels
area/development python Pull requests that update Python code type/improvement

Comments

@seriva
Copy link
Collaborator

seriva commented Feb 11, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently when Epicli is run it cleans out all *.tf Terraform template files. This restricts the ability of the user to add any kind of custom Terraform scripts to a deployment outside of what Epiphany generates.

Describe the solution you'd like
Only remove the Terraform templates from the build directory that are actually generated by Epiphany with the following regex:

'''[0-9][0-9][0-9]_*.tf'''

And document the steps for people to add custom Terraform templates to a deployed cluster.

Describe alternatives you've considered
None

Additional context
None

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@seriva seriva added type/improvement area/development python Pull requests that update Python code labels Feb 11, 2022
@seriva seriva self-assigned this Feb 11, 2022
This was referenced Feb 13, 2022
Merged
Closed
Closed
@przemyslavic przemyslavic self-assigned this Feb 24, 2022
seriva added a commit that referenced this issue Feb 24, 2022
@seriva
#2974 and #2976 (#2977)
d58ceab 
- Refactored Apply command #2974
- Added option for custom terraform scripts by the user #2976
- Moved Azure specific code from TerraformRunner to APIProxy
- Seperated filetype into schema and  template types.
- Fixed tests and sorted tests imports.
@przemyslavic
Copy link
Collaborator

The ability to add custom terraform scripts has been tested. The functionality seems to be working fine. Created and removed additional resources in AWS and Azure with epicli.

@seriva seriva closed this as completed Feb 28, 2022
@seriva seriva mentioned this issue Mar 11, 2022
Merged
seriva added a commit that referenced this issue May 11, 2022
@seriva @rafzei
@cicharka @plirglo
[1.0.3] backports (#3016)
80c2763 
* Added #2976

* Fixed #2992

* Fixed #2876

* Fixed #3004

* Fix #2934

* Added #1076

* Removed un-used certificate stuff

* Properly fixed #2876

* Add EOF EL

* Update CHANGELOG-1.0.md

Co-authored-by: Rafal Zeidler <[email protected]>

* azure: fix for #3065

* comment more entries for #2934

* Escalate permissions for ip command (#2952)

* Add documentation for custom terraform scripts

* Remove one more duplicate entry in image-registry defaults

Co-authored-by: Rafal Zeidler <[email protected]>
Co-authored-by: cicharka <[email protected]>
Co-authored-by: Irek Głownia <[email protected]>
Co-authored-by: przemyslavic <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

@przemyslavic przemyslavic

Labels
area/development python Pull requests that update Python code type/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seriva @przemyslavic