Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Duplicated entries in image-registry defaults (LTS) #2934

Closed
7 of 18 tasks
rafzei opened this issue Jan 27, 2022 · 0 comments
Closed
7 of 18 tasks

[BUG] Duplicated entries in image-registry defaults (LTS) #2934

rafzei opened this issue Jan 27, 2022 · 0 comments
Assignees
@seriva @przemyslavic
Labels
type/backport Backporting to previous versions type/bug

Comments

@rafzei
Copy link
Contributor

rafzei commented Jan 27, 2022 •
edited by seriva
Loading

Describe the bug
In the v1.0.2 we added validation for kind: configuration/image-registry
but we have duplicated entries in defaults
eg. k8s.gcr.io/etcd:3.4.3-0 and k8s.gcr.io/etcd:3.3.10

How to reproduce
Steps to reproduce the behavior:

  1. execute epicli init ... --full
  2. adjust config file
  3. execute epicli apply ...

Expected behavior
Validation passed, cluster up and running :)

Config files
default, generated with --full option

Environment

  • probably on all

epicli version: [epicli --version]
Appeared during LTS deployment (v1.0.2)

Additional context
Add any other context about the problem here.

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
@seriva seriva self-assigned this Mar 11, 2022
@seriva seriva added the type/backport Backporting to previous versions label Mar 11, 2022
@seriva seriva mentioned this issue Mar 11, 2022
Merged
seriva added a commit that referenced this issue May 11, 2022
@seriva @rafzei
@cicharka @plirglo
[1.0.3] backports (#3016)
80c2763 
* Added #2976

* Fixed #2992

* Fixed #2876

* Fixed #3004

* Fix #2934

* Added #1076

* Removed un-used certificate stuff

* Properly fixed #2876

* Add EOF EL

* Update CHANGELOG-1.0.md

Co-authored-by: Rafal Zeidler <[email protected]>

* azure: fix for #3065

* comment more entries for #2934

* Escalate permissions for ip command (#2952)

* Add documentation for custom terraform scripts

* Remove one more duplicate entry in image-registry defaults

Co-authored-by: Rafal Zeidler <[email protected]>
Co-authored-by: cicharka <[email protected]>
Co-authored-by: Irek Głownia <[email protected]>
Co-authored-by: przemyslavic <>
@seriva seriva closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

@przemyslavic przemyslavic

Labels
type/backport Backporting to previous versions type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seriva @rafzei @przemyslavic