Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "hotfix(file): cast dev to uint32" #2889

Merged
merged 2 commits into from
Dec 16, 2017
Merged

Revert "hotfix(file): cast dev to uint32" #2889

merged 2 commits into from
Dec 16, 2017

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Dec 6, 2017 •
edited
Loading

This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

Conflicts:

test/scripts/box/file.js

  • Passed the CI test.

Todo

  • Hold this PR until appveyor update node.js to 6.12.1

@coveralls
Copy link

coveralls commented Dec 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling 42e7c57 on revert-a2184229 into dee3b03 on master.

@coveralls
Copy link

coveralls commented Dec 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling 62df5a7 on revert-a2184229 into dee3b03 on master.

@coveralls
Copy link

coveralls commented Dec 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling 0b66c2e on revert-a2184229 into dee3b03 on master.

@coveralls
Copy link

coveralls commented Dec 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling b14c326 on revert-a2184229 into dee3b03 on master.

@JLHwung
Revert "hotfix(file): cast dev to uint32"
487c702 
This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.
@coveralls
Copy link

coveralls commented Dec 10, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling 487c702 on revert-a2184229 into dee3b03 on master.

@coveralls
Copy link

coveralls commented Dec 10, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.226% when pulling 0ea508b on revert-a2184229 into dee3b03 on master.

NoahDragon
NoahDragon approved these changes Dec 16, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This issue bugs me a long time.

@NoahDragon NoahDragon merged commit d4b4470 into master Dec 16, 2017
@NoahDragon NoahDragon deleted the revert-a2184229 branch December 16, 2017 02:15
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@JLHwung
Revert "hotfix(file): cast dev to uint32" (hexojs#2889)
b6e607e 
* Revert "hotfix(file): cast dev to uint32"

This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

* test(appveyor): update to exact node.js version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JLHwung @coveralls @NoahDragon