Skip to content

Commit

Permalink
Revert "hotfix(file): cast dev to uint32" (#2889)
Browse files Browse the repository at this point in the history
* Revert "hotfix(file): cast dev to uint32"

This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

* test(appveyor): update to exact node.js version
  • Loading branch information
JLHwung authored and NoahDragon committed Dec 16, 2017
1 parent c8d47b8 commit d4b4470
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 3 additions & 3 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ init:
# Test against these versions of Node.js.
environment:
matrix:
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "6.12.2"
- nodejs_version: "8.9.3"

matrix:
fast_finish: true

# Install scripts. (runs after repo cloning)
install:
- ps: Install-Product node $env:nodejs_version
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
- npm install -g npm
- npm install

Expand Down
2 changes: 0 additions & 2 deletions test/scripts/box/file.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ describe('File', () => {
file.stat((err, fileStats) => {
if (err) return callback(err);

//todo: cast dev to uint32 until https://github.com/nodejs/node/issues/16496 is resolved
fileStats.dev = (new Uint32Array([fileStats.dev]))[0];
fileStats.should.eql(fs.statSync(file.source));
callback();
});
Expand Down

0 comments on commit d4b4470

Please sign in to comment.