Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "hotfix(file): cast dev to uint32" #2889

Merged
merged 2 commits into from
Dec 16, 2017
Merged

Revert "hotfix(file): cast dev to uint32" #2889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
487c702
Revert "hotfix(file): cast dev to uint32"
JLHwung Dec 6, 2017
0ea508b
test(appveyor): update to exact node.js version
JLHwung Dec 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ init:
# Test against these versions of Node.js.
environment:
matrix:
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "6.12.2"
- nodejs_version: "8.9.3"

matrix:
fast_finish: true

# Install scripts. (runs after repo cloning)
install:
- ps: Install-Product node $env:nodejs_version
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
- npm install -g npm
- npm install

Expand Down
2 changes: 0 additions & 2 deletions test/scripts/box/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ describe('File', () => {
file.stat((err, fileStats) => {
if (err) return callback(err);

//todo: cast dev to uint32 until https://github.com/nodejs/node/issues/16496 is resolved
fileStats.dev = (new Uint32Array([fileStats.dev]))[0];
fileStats.should.eql(fs.statSync(file.source));
callback();
});
Expand Down