[stable/unbound] add clusterIP

[n0rad]

Add clusterIP value to unbound service

[k8s-ci-robot]

Hi @n0rad. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[n0rad]

/assign @scottrigby

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[n0rad]

I'm using unbound as a forward server for coredns and it can only be set by IP.
So to stay in the cluster, setting clusterIP is required.

@scottrigby can you review the PR please ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[n0rad]

@viglesiasce, can you review the PR ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[n0rad]

up

[zanhsieh]

/ok-to-test

[n0rad]

up

[scottrigby]

This chart doesn't appear to be maintained. No OWNERS file, one of the containers googlecontainer/exechealthz repo doesn't exist on docker hub anymore, so this doesn't install with default values (the source code repo was also retired: https://github.com/kubernetes-retired/contrib/tree/master/exec-healthz). Is this a good candidate for sunsetting?

[zanhsieh]

@scottrigby @n0rad
For me, yes, it's a good candidate for sunsetting, unless:

• The contributor(s) find other repo for hosting container.
• Find new chart owners.

I hope even chart sunsetting, it won't get deleted. Otherwise it will take a lot of efforts to climb back from incubator to stable.

[WyriHaximus]

• Find new chart owners.

Where do I sign up for that?

This chart doesn't appear to be maintained. No OWNERS file, one of the containers googlecontainer/exechealthz repo doesn't exist on docker hub anymore, so this doesn't install with default values (the source code repo was also retired: https://github.com/kubernetes-retired/contrib/tree/master/exec-healthz). Is this a good candidate for sunsetting?

Currently working on preparing a PR on fixing that dependency, also bumping the version of unbound, and also do some other small fixes in the chart it self like #18569 .

[zanhsieh]

@n0rad

I1106 07:55:44.573]   Warning  Failed     9m42s (x2 over 9m58s)  kubelet, gke-jenkins-default-pool-51cafeba-9gxc  Failed to pull image "googlecontainer/exechealthz:1.2": rpc error: code = Unknown desc = Error response from daemon: pull access denied for googlecontainer/exechealthz, repository does not exist or may require 'docker login'
I1106 07:55:44.573]   Warning  Failed     9m42s (x2 over 9m58s)  kubelet, gke-jenkins-default-pool-51cafeba-9gxc  Error: ErrImagePull

[WyriHaximus]

@n0rad I'm also looking into the specific error that @zanhsieh mentioned. Are you also doing that or should I continue?

[n0rad]

@WyriHaximus I'm not and was looking for your PR/issue, but I suppose you did not submitted it yet.

[WyriHaximus]

@n0rad haven't submitted it yet as I was intending to it in a PR that also bumps the image and some other stuff. But fixing this issue turned out a bit harder then I thought. I'll submit an issue about this issue and also mention that I'm working on a fix so if anyone else bumps into it they can more easily find out. 👍

[n0rad]

I added a commit to fix the exechealthz container that do not exists anymore and fixed the deprecated deployment app version that is not compatible with new versions of kubernetes.

I can join the maintainers if you need some.

[zanhsieh]

/retest

[davidkarlsen]

/assign
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, n0rad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidkarlsen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[WyriHaximus]

Sweet! This also resolves #18664 and closes #18683 👍