Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/quassel] Update image and deployment apiVersion #18569

Merged
merged 2 commits into from
Jul 18, 2020
Merged

[stable/quassel] Update image and deployment apiVersion #18569

merged 2 commits into from
Jul 18, 2020

Conversation

WyriHaximus
Copy link
Contributor

For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file: @kiall

What this PR does / why we need it:

Ensures that this chart works on the latest versions of Helm and update to the latest version of the used Docker image

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @WyriHaximus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 5, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2019
@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 5, 2019
@WyriHaximus WyriHaximus mentioned this pull request Nov 5, 2019
Merged
@WyriHaximus
Copy link
Contributor Author

/assign @kiall

davidkarlsen
davidkarlsen suggested changes Nov 5, 2019
View reviewed changes
stable/quassel/Chart.yaml Outdated Show resolved Hide resolved
@WyriHaximus
[stable/quassel] Update to latest quassel-core image tag
c1953bc 
The current tag is two+ years old and new versions have been released.
Also the repo seems to do weekly/monthly image update to unsure all
packages inside are up te date.

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
@WyriHaximus
[stable/quassel] Update apiVersion to apps/v1
c0b3f45 
apps/v1beta2 isn't supported anymore on the latest k8s. (Tested on this
1.16.)

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 6, 2019

/retest

@WyriHaximus
Copy link
Contributor Author

Is there a way I can help move this forward?

@stale
Copy link

stale bot commented Dec 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2019
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2019
@stale
Copy link

stale bot commented Jan 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@stale
Copy link

stale bot commented Feb 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2020
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2020
@stale
Copy link

stale bot commented Apr 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@stale
Copy link

stale bot commented May 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2020
@stale
Copy link

stale bot commented Jun 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@WyriHaximus
Copy link
Contributor Author

Bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@davidkarlsen
Copy link
Member

/assign
/lgtm
Sorry for the delay!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, WyriHaximus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2ace5c8 into helm:master Jul 18, 2020
@WyriHaximus WyriHaximus deleted the update-quassel branch July 18, 2020 14:55
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@WyriHaximus @includerandom
[stable/quassel] Update image and deployment apiVersion (helm#18569)
c47b40f 
* [stable/quassel] Update to latest quassel-core image tag

The current tag is two+ years old and new versions have been released.
Also the repo seems to do weekly/monthly image update to unsure all
packages inside are up te date.

Signed-off-by: Cees-Jan Kiewiet <[email protected]>

* [stable/quassel] Update apiVersion to apps/v1

apps/v1beta2 isn't supported anymore on the latest k8s. (Tested on this
1.16.)

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
@WyriHaximus
Copy link
Contributor Author

Sorry for the delay!

No problem, I had a really good chat with stale 😋

KinsheX pushed a commit to KinsheX/charts that referenced this pull request Jul 20, 2020
@WyriHaximus @KinsheX
[stable/quassel] Update image and deployment apiVersion (helm#18569)
f5ab4bb 
* [stable/quassel] Update to latest quassel-core image tag

The current tag is two+ years old and new versions have been released.
Also the repo seems to do weekly/monthly image update to unsure all
packages inside are up te date.

Signed-off-by: Cees-Jan Kiewiet <[email protected]>

* [stable/quassel] Update apiVersion to apps/v1

apps/v1beta2 isn't supported anymore on the latest k8s. (Tested on this
1.16.)

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@WyriHaximus @li-adrienloiseau
[stable/quassel] Update image and deployment apiVersion (helm#18569)
3feb011 
* [stable/quassel] Update to latest quassel-core image tag

The current tag is two+ years old and new versions have been released.
Also the repo seems to do weekly/monthly image update to unsure all
packages inside are up te date.

Signed-off-by: Cees-Jan Kiewiet <[email protected]>

* [stable/quassel] Update apiVersion to apps/v1

apps/v1beta2 isn't supported anymore on the latest k8s. (Tested on this
1.16.)

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@WyriHaximus
[stable/quassel] Update image and deployment apiVersion (helm#18569)
7c65baf 
* [stable/quassel] Update to latest quassel-core image tag

The current tag is two+ years old and new versions have been released.
Also the repo seems to do weekly/monthly image update to unsure all
packages inside are up te date.

Signed-off-by: Cees-Jan Kiewiet <[email protected]>

* [stable/quassel] Update apiVersion to apps/v1

apps/v1beta2 isn't supported anymore on the latest k8s. (Tested on this
1.16.)

Signed-off-by: Cees-Jan Kiewiet <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@jlegrone jlegrone Awaiting requested review from jlegrone

@kiall kiall Awaiting requested review from kiall

Assignees

@davidkarlsen davidkarlsen

@kiall kiall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WyriHaximus @k8s-ci-robot @zanhsieh @davidkarlsen @kiall @mattfarina @helm-bot