Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/unbound] Add n0rad as maintainer #18950

Merged
merged 1 commit into from
Nov 26, 2019
Merged

[stable/unbound] Add n0rad as maintainer #18950

merged 1 commit into from
Nov 26, 2019

Conversation

n0rad
Copy link
Contributor

@n0rad n0rad commented Nov 18, 2019

Following #15304 and #13869, applying to be a maintainer of unbound.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 18, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @n0rad. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2019
@n0rad
Copy link
Contributor Author

n0rad commented Nov 18, 2019

/assign @viglesiasce

@scottrigby
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2019
@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n0rad, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit e8f3e24 into helm:master Nov 26, 2019
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@n0rad
[stable/unbound] Add n0rad as maintainer (helm#18950)
17c644e 
Signed-off-by: Arnaud Lemaire <[email protected]>
Signed-off-by: Carlos Roberto Marques Junior <[email protected]>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@n0rad
[stable/unbound] Add n0rad as maintainer (helm#18950)
998c7a3 
Signed-off-by: Arnaud Lemaire <[email protected]>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@n0rad @dargolith
[stable/unbound] Add n0rad as maintainer (helm#18950)
34a0bf3 
Signed-off-by: Arnaud Lemaire <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlegrone jlegrone Awaiting requested review from jlegrone

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@viglesiasce viglesiasce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n0rad @k8s-ci-robot @scottrigby @viglesiasce @helm-bot