Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes from CLV Study #91

Draft
wants to merge 15 commits into
base: vinitha/firebase
Choose a base branch
from
Draft

Changes from CLV Study #91

wants to merge 15 commits into from

Conversation

hello-amal
Copy link
Collaborator

Description

Eventually, we should merge all these changes into master. Some that may require additional work include:

  • Just like in click-to-pregrasp we rotate the yaw first and then the pitch+roll when deploying the wrist, we should consider adding that to the web app for "center wrist."
  • As opposed to hardcoding gTTS audio to 400%, we should add it to the configuration of the engine (and, hence, the ROS message), just like is_slow or voice_id. This change should also be mirrored in stretchpy#61 and stretch_ai#57

Testing procedure

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-amal hello-amal marked this pull request as draft August 1, 2024 15:13
@hello-amal hello-amal force-pushed the studies/clv branch 2 times, most recently from a3ae2f5 to 34b8b85 Compare August 2, 2024 22:50
@hello-amal hello-amal changed the base branch from master to vinitha/firebase August 6, 2024 20:28
@hello-amal hello-amal mentioned this pull request Aug 9, 2024
Merged
8 tasks
hello-amal and others added 5 commits August 9, 2024 16:02
@hello-amal @bm-hellorobot
Update README with new features, and other small fixes (#95)
7b5af76 
* Expand configure audio to work with multiple audio devices

* Replace Cap with Capture to avoid matching Capabilities

* Update movement recorder joint selection UI and state change

* Document new features in README

* Add READMEs

* Rename gripper_depth_sensing.gif to gripper_depth_overlay.gif

---------

Co-authored-by: Blaine Matulevich <[email protected]>
Co-authored-by: Amal Nanavati <[email protected]>
@hello-binit
Remove numpy pin in Web Teleop (#97)
7323105 
* Remove numpy pin in Web Teleop

This commits removes the pin on an older version of numpy. Stretch Body now pins the right version of numpy. Details in these two PRs:
 - hello-robot/stretch_body#349
 - hello-robot/stretch_body#348

* Numpy primitives deprecated

With numpy 1.24 and onwards, using np.bool and other np.<primitive>
types is deprecated, and raises exceptions. We are supposed to use
the built-in primitives (i.e. bool, float, etc.).
@hello-vinitha
Merge branch 'master' into studies/clv
6b43495
@hello-vinitha
offline icons for map
fbae646
@hello-vinitha
temp fix for firebase crash when adding map to layout
c6f3959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hello-amal @hello-binit @hello-vinitha