Pinocchio requires lower numpy version #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the latest 1.x version of numpy (1.26.4) is not possible with Pinoochio, a dependency of Web Teleop, because it depends on cmeel-boost, which depends on numpy 1.24.x. In a previous PR, we increased the numpy version from 1.23.x to make trimesh happy. To keep both happy, this commit pins on >=1.24
hello-binit
added a commit
to hello-robot/stretch_web_teleop
that referenced
this pull request
Aug 25, 2024
This commits removes the pin on an older version of numpy. Stretch Body now pins the right version of numpy. Details in these two PRs: - hello-robot/stretch_body#349 - hello-robot/stretch_body#348
hello-binit
added a commit
to hello-robot/stretch_web_teleop
that referenced
this pull request
Sep 4, 2024
* Remove numpy pin in Web Teleop This commits removes the pin on an older version of numpy. Stretch Body now pins the right version of numpy. Details in these two PRs: - hello-robot/stretch_body#349 - hello-robot/stretch_body#348 * Numpy primitives deprecated With numpy 1.24 and onwards, using np.bool and other np.<primitive> types is deprecated, and raises exceptions. We are supposed to use the built-in primitives (i.e. bool, float, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest 1.x version of numpy (1.26.4) is not possible with Pinoochio, a dependency of Web Teleop, because it depends on cmeel-boost, which depends on numpy 1.24.x. In a previous PR, we increased the numpy version from 1.23.x to make trimesh happy. To keep both happy, this commit pins on >=1.24
Follow up to PR #348