Support Bazel 5 #156
Merged
Support Bazel 5 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is only available in Bazel >= 6.1.0.
…ey're not supplied from aquery output In Bazel < 6.1.0, aquery doesn't provide environment variables. See hedronvision#154 for more context.
Since `repository_name()` already contains leading `@`, we don't need to prefix it with `@`. Previously, it would produce double at-sign `@@` addressing [canonical repository name](https://bazel.build/external/overview#canonical-repo-name) which is a syntax introduced in Bazel 6.0, so it failed to run aquery command on Bazel < 6.0.
|
Thanks so much for doing, Kon. (Doubly good catch on the @. I think maybe at the time it was originally written, it wasn't included in the repo name, but maybe not.) |
|
Again, really appreciate your being so excellent to work with. Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports Bazel 5.
Please see the commit message in each commit for details.
Fixes #153