Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bazel 5 #156

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Support Bazel 5 #156

merged 4 commits into from
Jan 8, 2024

Commits on Jan 7, 2024

  1. Enable --host_features=-compiler_param_file only when Bazel >= 6.1.0 

    This flag is only available in Bazel >= 6.1.0.
    @kon72
    kon72 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    f7e54ab View commit details
    Browse the repository at this point in the history

  2. Construct environment variables necessary to run emcc process when th… 

    …ey're not supplied from aquery output

In Bazel < 6.1.0, aquery doesn't provide environment variables.
See hedronvision#154 for more context.
    @kon72
    kon72 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    3cf87f6 View commit details
    Browse the repository at this point in the history

  3. Remove spurious leading @ from target name 

    Since `repository_name()` already contains leading `@`, we don't need to prefix it with `@`.
Previously, it would produce double at-sign `@@` addressing [canonical repository name](https://bazel.build/external/overview#canonical-repo-name) which is a syntax introduced in Bazel 6.0, so it failed to run aquery command on Bazel < 6.0.
    @kon72
    kon72 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    3ade9a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge branch 'main' into support_bazel_5

    @cpsauer
    cpsauer authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    fb91692 View commit details
    Browse the repository at this point in the history