Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--host_features=compiler_param_file need bazel >= 6.1.0 #153

Closed
doupongzeng opened this issue Dec 22, 2023 · 5 comments · Fixed by #156
Closed

--host_features=compiler_param_file need bazel >= 6.1.0 #153

doupongzeng opened this issue Dec 22, 2023 · 5 comments · Fixed by #156

Comments

@doupongzeng
Copy link

[6.1.0] Add --host_features

I think it's possible to add a version number check during execution; otherwise, error messages can be confusing and unclear at first.

@cpsauer
Copy link
Contributor

cpsauer commented Dec 22, 2023

Yes--to make sure I'm on the same page, you're running an old version of Bazel < 6.1 where our passing host_features breaks things, yes?

If you can't just update, would you be down to toss up a PR so we call bazel version from inside the python script and parse it and use that to gate the addition of the flag, and make sure all still works for you?

Preferably with a fn just above _get_compile_commands_for_aquery like:

@functools.lru_cache(maxsize=None)
def _get_bazel_version():
    subprocess.run(
...
return <version tuple>

@cpsauer
Copy link
Contributor

cpsauer commented Jan 2, 2024

@doupongzeng, how much do you need the old version? We're thinking about whether we need to support 6.1 in another feature, #154

@doupongzeng
Copy link
Author

@doupongzeng, how much do you need the old version? We're thinking about whether we need to support 6.1 in another feature, #154

I am currently using version 5.1.0, and I have temporarily removed the --host_features=compiler_param_file, which also works.

@cpsauer
Copy link
Contributor

cpsauer commented Jan 3, 2024

I understand. Is upgrading an option? And if not, would you be down to toss up a PR as above, and chime in on #154 asking for backwards compatibility? He'll know what you mean.

@doupongzeng
Copy link
Author

I understand. Is upgrading an option? And if not, would you be down to toss up a PR as above, and chime in on #154 asking for backwards compatibility? He'll know what you mean.

Sure, I can try this weekend. Upgrading the version seems infeasible right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants