Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate status checks from dependent S6 services #196

Merged

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Apr 29, 2023

Proposed Changes

Minor code quality improvement.

The proxy and taildrop services are waiting for post-tailscaled, so move the status checks from the beginning of proxy and taildrop to the end of post-tailscaled.

Related Issues

@seagyn
Copy link

seagyn commented May 22, 2023

@lmagyar Are you able to add labels to this? I see it's the only action that fails. I'd like to see funnel getting implemented.

@frenck
Copy link
Member

frenck commented May 22, 2023

@lmagyar Are you able to add labels to this? I see it's the only action that fails. I'd like to see funnel getting implemented.

No, that is not how GitHub works, nor is that a concern or limiting factor at this point.

../Frenck

@seagyn
Copy link

seagyn commented May 22, 2023

Sorry, I was referring to this:

image

image

With the hope that if all the checks were passing before pinging you to ask what is preventing something like this from going in? I'm mainly interested in #197

@frenck
Copy link
Member

frenck commented May 23, 2023

I know what you are referring too... but your comment makes no sense, and only shows you have no clue on how GitHub even works...

We all have interest in many things. Pinging won't help either. If anything, a ping makes me skip things on purpose, as I don't want / will lure myself into a system of "handling the loudest".

Just be patient please. 🙏

../Frenck

@seagyn
Copy link

seagyn commented May 23, 2023

I'm sorry Frank, I'm not sure why their is aggression here after a simple question not even directed at you. I know very well how GitHub works, thanks.

I won't hold my breath especially after a threat like that. Literally no one was putting pressure but purely stating a desire.

Cheers.

@frenck
Copy link
Member

frenck commented May 23, 2023

A threat / aggression? Are you ok? :)

Don't take it so heavy. I am just explaining that you comment on labels didn't make sense, as a PR contributor/author can't set them, thus you might not be aware how GitHub works.

Additionally you mentioned about pinging, but that is something that can be demanding, even when not meant that way. 🤷‍♂️

There is no aggression or mad face from my end at all here 😕

../Frenck

@seagyn
Copy link

seagyn commented May 23, 2023

I'm ok, thanks.

You first response is an overarching statement that I have no idea how GitHub works when a "PR contributors cannot add labels and this isn't the blocker for this. I'll give feedback in due course." Is much less aggressive.

Anyway, thanks for all your open source projects and contributions. There was no intention to put pressure on you at all but rather to see if I could help this along in anyway.

Cheers.

@frenck
Copy link
Member

frenck commented May 23, 2023

You first response is an overarching statement

Is much less aggressive.

Sorry, are you mocking me right now? Are you bored or like to mess with people? As in, approach the world more positively by maybe not assuming assume the bad in people.

that I have no idea how GitHub works

Sorry, well, if you knew, that makes your initial question weird as hell, as it could not be fulfilled by the person you're asked to add a label... 🤷 I'm not understanding the point you make in any of your follow-ups in that case.

There was no intention to put pressure on you at all but rather to see if I could help this along in anyway.

I don't see how any of the above would have achieved that. To be fair, it only raised noise 🤷

../Frenck

@seagyn
Copy link

seagyn commented May 23, 2023

Cool got it. Don't raise any questions in this repo 👍

@frenck
Copy link
Member

frenck commented May 23, 2023

Really now? haha, that is what you took from it?

But if the above is how you would communicate further, I would definitely not mind your policy on that 😄

@lmagyar lmagyar force-pushed the pr-remove-duplicate-status-checks branch from d1c44b3 to 02f2471 Compare June 1, 2023 09:43
@lmagyar lmagyar force-pushed the pr-remove-duplicate-status-checks branch from 02f2471 to 6685337 Compare June 23, 2023 08:40
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 24, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Jul 24, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 25, 2023
@lmagyar lmagyar force-pushed the pr-remove-duplicate-status-checks branch from 6685337 to 0364f29 Compare August 6, 2023 11:13
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Sep 6, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Sep 6, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Sep 7, 2023
@lmagyar lmagyar force-pushed the pr-remove-duplicate-status-checks branch from 0364f29 to df217b8 Compare September 7, 2023 19:32
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 8, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 8, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 9, 2023
@frenck frenck force-pushed the pr-remove-duplicate-status-checks branch from df217b8 to c02f203 Compare October 15, 2023 16:22
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Oct 15, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 5e26744 into hassio-addons:main Oct 15, 2023
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@lmagyar lmagyar deleted the pr-remove-duplicate-status-checks branch October 18, 2023 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants