-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate status checks from dependent S6 services #196
Remove duplicate status checks from dependent S6 services #196
Conversation
@lmagyar Are you able to add labels to this? I see it's the only action that fails. I'd like to see funnel getting implemented. |
No, that is not how GitHub works, nor is that a concern or limiting factor at this point. ../Frenck |
Sorry, I was referring to this: With the hope that if all the checks were passing before pinging you to ask what is preventing something like this from going in? I'm mainly interested in #197 |
I know what you are referring too... but your comment makes no sense, and only shows you have no clue on how GitHub even works... We all have interest in many things. Pinging won't help either. If anything, a ping makes me skip things on purpose, as I don't want / will lure myself into a system of "handling the loudest". Just be patient please. 🙏 ../Frenck |
I'm sorry Frank, I'm not sure why their is aggression here after a simple question not even directed at you. I know very well how GitHub works, thanks. I won't hold my breath especially after a threat like that. Literally no one was putting pressure but purely stating a desire. Cheers. |
A threat / aggression? Are you ok? :) Don't take it so heavy. I am just explaining that you comment on labels didn't make sense, as a PR contributor/author can't set them, thus you might not be aware how GitHub works. Additionally you mentioned about pinging, but that is something that can be demanding, even when not meant that way. 🤷♂️ There is no aggression or mad face from my end at all here 😕 ../Frenck |
I'm ok, thanks. You first response is an overarching statement that I have no idea how GitHub works when a "PR contributors cannot add labels and this isn't the blocker for this. I'll give feedback in due course." Is much less aggressive. Anyway, thanks for all your open source projects and contributions. There was no intention to put pressure on you at all but rather to see if I could help this along in anyway. Cheers. |
Sorry, are you mocking me right now? Are you bored or like to mess with people? As in, approach the world more positively by maybe not assuming assume the bad in people.
Sorry, well, if you knew, that makes your initial question weird as hell, as it could not be fulfilled by the person you're asked to add a label... 🤷 I'm not understanding the point you make in any of your follow-ups in that case.
I don't see how any of the above would have achieved that. To be fair, it only raised noise 🤷 ../Frenck |
Cool got it. Don't raise any questions in this repo 👍 |
Really now? haha, that is what you took from it? But if the above is how you would communicate further, I would definitely not mind your policy on that 😄 |
d1c44b3
to
02f2471
Compare
02f2471
to
6685337
Compare
This comment was marked as resolved.
This comment was marked as resolved.
not stale |
6685337
to
0364f29
Compare
This comment was marked as resolved.
This comment was marked as resolved.
not stale |
0364f29
to
df217b8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
not stale |
df217b8
to
c02f203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lmagyar 👍
../Frenck
Proposed Changes
Minor code quality improvement.
The
proxy
andtaildrop
services are waiting forpost-tailscaled
, so move the status checks from the beginning ofproxy
andtaildrop
to the end ofpost-tailscaled
.Related Issues