Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about key expiration #255

Merged
merged 4 commits into from
Oct 15, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Sep 9, 2023

Note: this is based on / continuation of #196, but I will rebase this PR as required.

Proposed Changes

When key expiration is not disabled, users can lose connection to their remote, only tailscale-accessible devices. It is mentioned in the DOCS, but better to warn about it also.

Related Issues

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 9, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 10, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 11, 2023
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Oct 15, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit ce42316 into hassio-addons:main Oct 15, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@lmagyar lmagyar deleted the pr-warn-about-key-expiration branch October 18, 2023 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants