-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make userspace networking configurable #199
Make userspace networking configurable #199
Conversation
I have one of my own test instances that has the same problem (which is the main reason for it not being released yet). However, I don't think this a solution nor a workaround. In some situations loosing access is problematic and would also prevent one from accessing this workaround. Not all devices used for HA have access to the system terminal. ../Frenck |
99d085d
to
59e1ba5
Compare
59e1ba5
to
ac60c97
Compare
This comment was marked as resolved.
This comment was marked as resolved.
not stale, also multiple PR-s are based on this |
ac60c97
to
58711b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
not stale |
58711b0
to
8751cf7
Compare
953b563
to
09a41fa
Compare
Needs #201 first (and a rebase). |
Let's just do it. ../Frenck |
09a41fa
to
223fbd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lmagyar 👍
../Frenck
Yes, I just afraid that turning off userspace networking can mess up configs. Most of the people will not use tailscale0/tunneling I think. |
Note: this is based on / continuation of #196, but I will rebase this PR as required.
Proposed Changes
The currently unreleased #181 dropped userspace networking automatically.
I've merged it into my fork, and 1 user complained, that his host lost all network access (even local 192.168.x.x did not worked). UPDATE: The reason must be that the same subnet is advertised at multiple locations and it caused collision. The PR #201 provides a possible solution for collision, but I think making userspace-networking configurable still makes sense.
This PR makes it configurable, by default the add-on still uses userspace networking, but if somebody adds
userspace_networking: false
to the configuration, it will drop it and create thetailscale0
interface with all of the dangers of it.But at least it requires manual intervention and doesn't happen automatically during an add-on update.
Related Issues