Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make userspace networking configurable #199

Merged

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented May 10, 2023

Note: this is based on / continuation of #196, but I will rebase this PR as required.

Proposed Changes

The currently unreleased #181 dropped userspace networking automatically.

I've merged it into my fork, and 1 user complained, that his host lost all network access (even local 192.168.x.x did not worked). UPDATE: The reason must be that the same subnet is advertised at multiple locations and it caused collision. The PR #201 provides a possible solution for collision, but I think making userspace-networking configurable still makes sense.

This PR makes it configurable, by default the add-on still uses userspace networking, but if somebody adds userspace_networking: false to the configuration, it will drop it and create the tailscale0 interface with all of the dangers of it.

But at least it requires manual intervention and doesn't happen automatically during an add-on update.

Related Issues

@frenck
Copy link
Member

frenck commented May 10, 2023

I have one of my own test instances that has the same problem (which is the main reason for it not being released yet).

However, I don't think this a solution nor a workaround. In some situations loosing access is problematic and would also prevent one from accessing this workaround. Not all devices used for HA have access to the system terminal.

../Frenck

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 27, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Jul 27, 2023

not stale, also multiple PR-s are based on this

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 28, 2023
@lmagyar lmagyar force-pushed the pr-make-userspace-networking-configurable branch from ac60c97 to 58711b0 Compare August 6, 2023 11:14
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Sep 6, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Sep 6, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Sep 7, 2023
@lmagyar lmagyar force-pushed the pr-make-userspace-networking-configurable branch from 58711b0 to 8751cf7 Compare September 7, 2023 19:32
@lmagyar lmagyar force-pushed the pr-make-userspace-networking-configurable branch 2 times, most recently from 953b563 to 09a41fa Compare October 2, 2023 20:49
@frenck
Copy link
Member

frenck commented Oct 15, 2023

Needs #201 first (and a rebase).

@frenck frenck added the new-feature New features or options. label Oct 15, 2023
@frenck frenck marked this pull request as draft October 15, 2023 17:08
@frenck
Copy link
Member

frenck commented Oct 15, 2023

but I think making userspace-networking configurable still makes sense.

I'm not sure why? I think we should just drop it fully.

Let's just do it.

../Frenck

@frenck frenck force-pushed the pr-make-userspace-networking-configurable branch from 09a41fa to 223fbd8 Compare October 15, 2023 19:13
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/translations/en.yaml Outdated Show resolved Hide resolved
@frenck frenck marked this pull request as ready for review October 15, 2023 19:15
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 4318158 into hassio-addons:main Oct 15, 2023
13 checks passed
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 16, 2023

but I think making userspace-networking configurable still makes sense.

I'm not sure why? I think we should just drop it fully.

Let's just do it.

../Frenck

Yes, I just afraid that turning off userspace networking can mess up configs. Most of the people will not use tailscale0/tunneling I think.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@lmagyar lmagyar deleted the pr-make-userspace-networking-configurable branch October 18, 2023 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants