Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logo option UwU #292

Merged
merged 10 commits into from
May 5, 2024
Merged

Add Logo option UwU #292

merged 10 commits into from
May 5, 2024

Conversation

HEIGE-PCloud
Copy link
Contributor

@HEIGE-PCloud HEIGE-PCloud commented May 1, 2024

Overview

Adds a query param to switch the Haskell logo to https://github.com/SAWARATSUKI/ServiceLogos:

  • on: ?uwu=true
  • off: ?uwu=false
    Setting will persist until you turn it off.

Screen

327063873-4bb93066-6606-4fab-9c5c-c54c94836630

Credits

Credit to @SAWARATSUKI in https://github.com/SAWARATSUKI/ServiceLogos

Context

site/templates/default.html Outdated Show resolved Hide resolved
site/templates/default.html Outdated Show resolved Hide resolved
site/css/hl.css Outdated Show resolved Hide resolved
site/templates/default.html Outdated Show resolved Hide resolved
@tomjaguarpaw
Copy link
Collaborator

Could someone explain what this is about? I don't understand.

@Kleidukos
Copy link
Collaborator

@tomjaguarpaw Someone made cute alternative logos of projects: https://github.com/SAWARATSUKI/ServiceLogos

Some of them are already using them.

That being said since offering the logo from a third-party person is not a trivial matter I'd feel better if the committee would vote on this.

@HEIGE-PCloud
Copy link
Contributor Author

HEIGE-PCloud commented May 1, 2024

@tomjaguarpaw It's basically a meme. Feel free to close this if this does not align well with the project.

@aviaviavi
Copy link
Collaborator

What's the license associated this logo?

Fun and lighthearted memes like this seem fine, very low risk, and a nice little social media opportunity - if the logo is permissive licensed. Dealing with any license obligations just for this seems unnecessary though.

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

I agree, I think it would be fun. The license is CC BY-NC-SA, so we should be good: https://github.com/SAWARATSUKI/ServiceLogos?tab=readme-ov-file#license. I suggest we move quickly on this, could be good PR as you say.

@Kleidukos
Copy link
Collaborator

I don't disagree with including the logo, I just want to focus on maintainability of the code. :)

@mpilgrem
Copy link
Contributor

mpilgrem commented May 2, 2024

Given the general importance of logos/trade marks, I suggest that this is not merged until the Haskell.org Committee and/or the board of directors of Haskell.org, Inc. have had a chance to consider the implications of doing so.EDIT: The board of directors next meets on 9 May 2024, so that would not introduce a long delay.

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

The "collaborators" here are the committee 😄

But I agree, we should have consensus. @rebeccaskinner, @aaronallen8455, @angerman, thoughts?

I think it's OK, particularly since it is only enabled if you pass a specific string during the request. If React feels comfortable with it, I think we should be OK too.

@mpilgrem
Copy link
Contributor

mpilgrem commented May 2, 2024

One thing I would like the Haskell.org Committee to reflect upon is the use of the 'bag of money' iconography in the image. As far as I can see, none of the other examples has something similar.

Also, I do not read Japanese. Is there any perceived meaning to the Japanese characters included in the image? EDIT: I've answered this question: Google Translate tells me ハスケル reads 'Haskell'.

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

One thing I would like the Haskell.org Committee to reflect upon is the use of the 'bag of money' iconography in the image. As far as I can see, none of the other examples has something similar.

That's a good point. I'll tweak it and remove the moneybag.

@juhp
Copy link
Contributor

juhp commented May 2, 2024

That's a good point. I'll tweak it and remove the moneybag.

It would make more sense to replace the bag with <$>...

(This comment is in no way an endorsement;)

@mpilgrem
Copy link
Contributor

mpilgrem commented May 2, 2024

@Tritlo, on your tweak, which leaves a gap, I would have no anxiety about any <icon>.hs where <icon> can only, realistically, have 'positive' connotations. 😊.hs

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

Hmm yes, but the React and Hono logos have no emojis at all. I thought to keep it simple.

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

That's a good point. I'll tweak it and remove the moneybag.

It would make more sense to replace the bag with <$>...

(This comment is in no way an endorsement;)

Alright! I updated it again, moving the <$> in place of the money bag,

Copy link
Collaborator

@Tritlo Tritlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change uwu to alternative-logo in the CSS.

site/templates/default.html Outdated Show resolved Hide resolved
site/css/hl.css Outdated Show resolved Hide resolved
site/css/hl.css Outdated Show resolved Hide resolved
site/css/hl.css Outdated Show resolved Hide resolved
site/index.html Outdated Show resolved Hide resolved
site/index.html Outdated Show resolved Hide resolved
site/index.html Outdated Show resolved Hide resolved
site/templates/default.html Outdated Show resolved Hide resolved
site/templates/default.html Outdated Show resolved Hide resolved
@rhendric
Copy link

rhendric commented May 2, 2024

Really wasn't intending to yuck anyone's yum. If this is reverted after some short period of time (I don't see anything suggesting that it would be above this comment, so I don't think it was terribly out of pocket for me to think that this was intended to stick around long-term), I have no objection.

@Tritlo
Copy link
Collaborator

Tritlo commented May 2, 2024

It would most certainly be temporary. This is in no way a permanent alternative logo, and I don't believe it was suggested as such.

@Abastro
Copy link

Abastro commented May 3, 2024

Huh, why is this 'uwu'? Sorry that I am missing a lot.

@Kleidukos
Copy link
Collaborator

The repo and the original images (and licenses) have disappeared. I'm afraid this is going to be blocked until we can reliably get a source and license for the images. Also I wonder what motivated the deletion of the repo.

@Tritlo
Copy link
Collaborator

Tritlo commented May 3, 2024

The author had this to say on Twitter:

To clean up the license, make the repository private and create a new one.

Please wait until it is re-released 🫠

image

So I guess we'll wait until the license is clarified.

@kutyel
Copy link

kutyel commented May 3, 2024

The repo and the original images (and licenses) have disappeared. I'm afraid this is going to be blocked until we can reliably get a source and license for the images. Also I wonder what motivated the deletion of the repo.

The logos will come back soon with I presume a more open license, I think the repo will be this: https://github.com/SAWARATSUKI/Logos (empty for now)

@aaronallen8455
Copy link
Collaborator

aaronallen8455 commented May 3, 2024

I don't have a strong opinion but I'm generally in favor of this as long as the licensing isn't an issue. The edit that @Tritlo made addresses my main complaint with the logo, although I think the purple drop shadow effect doesn't work well with the image placed on a white background. Maybe if the logo used a slightly off-white color then it would look better with the white background of the site (perhaps the same shade of grey that is used for the code example box). Alternatively, the drop shadow could be edited out.

@SAWARATSUKI
Copy link

I am the creator of the logo
I created this as pure fan art with no intention of dissatisfaction or opposition to the Haskell people.
First of all, I'll admit if I made you dissatisfied.

If the official uses it, you are free to use it for anything, including commercial use!🫠
I plan to make it impossible to use it for commercial purposes other than official use!

@angerman
Copy link
Collaborator

angerman commented May 4, 2024

I'm not opposed to this. I did see the one with the money bag before and found that a bit questionable too. But the current one, I have no objections to. We all need a bit of fun in life. ✌️

@SAWARATSUKI
Copy link

I only used 💰 because I remembered hearing from a friend that Haskell is used in banking and added it.
My apologies.
I'm glad too that you like the modified logo 🫠.
Please use it as you wish!

@HEIGE-PCloud
Copy link
Contributor Author

HEIGE-PCloud commented May 4, 2024

I am considering to start using

(💰) :: (a -> b) -> a -> b
(💰) = ($)

(◀💰▶) :: Functor f => (a -> b) -> f a -> f b
(◀💰▶) = (<$>)

from now on 👿

@kutyel
Copy link

kutyel commented May 4, 2024

@Kleidukos if we have written permission from the author of the logos to use the modified version is there a reason to keep holding this? 👀

@Tritlo
Copy link
Collaborator

Tritlo commented May 4, 2024

We still need a green light from @rebeccaskinner and @tomjaguarpaw. Are you ok with this?

@tomjaguarpaw
Copy link
Collaborator

I'm going to abstain. I still don't really understand what this is.

@hmemcpy
Copy link

hmemcpy commented May 4, 2024

Haskell: Avoid fun at all cost

just merge this already! :D

@ekmett
Copy link

ekmett commented May 4, 2024

I just wanted to chime in and say that this logo is all kinds of awesome. Great work.

@ekmett
Copy link

ekmett commented May 4, 2024

I am considering to start using

(💰) :: (a -> b) -> a -> b
(💰) = ($)

If you're going to make another operator, you might try flipping the associativity, along with an appropriate (💰!) for strict application.

with that 💰 you can use 💰 it to divide 💰! multi-part arguments = 
with that (you can use) (it to divide) $! multi-part arguments

and say which ones you want to apply strictly, and . still works, so now the . vs $ debate goes away, as there is now a canonical choice. That said, having built a language that used it that way, I er.. eventually relented and switched back because the muscle memory was too strong for the other meaning.

Copy link
Collaborator

@rebeccaskinner rebeccaskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the meme, but I'm happy for haskell.org to participate in a fun thing and this seems harmless.

Tested this with javascript enabled and disabled on Firefox and Chromium, didn't see any adverse impact and it looks straightforward.

@aaronallen8455
Copy link
Collaborator

aaronallen8455 commented May 5, 2024

Fwiw, I found that adding filter: drop-shadow(0px 0px 1px black); to the CSS rules for the image makes it look a bit better against a white background:
Screenshot 2024-05-05 at 2 19 29 AM

@Tritlo
Copy link
Collaborator

Tritlo commented May 5, 2024

Seems like we have consensus! @Kleidukos, are you satisfied with the licensing after the written permission?

I'll integrate the drop-shadow @aaronallen8455, and do one last test on whether we need the try-catch for localstorage for some permission configurations.

@Tritlo
Copy link
Collaborator

Tritlo commented May 5, 2024

Seems like we have consensus! @Kleidukos, are you satisfied with the licensing after the written permission?

(I need you to approve the changes in the GitHub interface also)

@Tritlo Tritlo requested a review from Kleidukos May 5, 2024 08:39
Copy link
Collaborator

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Tritlo Tritlo merged commit de64b89 into haskell-infra:master May 5, 2024
1 check passed
@Tritlo
Copy link
Collaborator

Tritlo commented May 5, 2024

It's up! Thanks everyone.

@Kleidukos
Copy link
Collaborator

Official announcement: https://discourse.haskell.org/t/cute-alternative-logo-for-haskell-org/9473

@MRandl
Copy link

MRandl commented May 5, 2024

It renders in a weird manner on my phone. Not a big deal but I thought you should know

Screenshot_20240505-112932.png

Screenshot_20240505-112906.png

Pixel 7a on firefox

@Tritlo
Copy link
Collaborator

Tritlo commented May 5, 2024

It renders in a weird manner on my phone. Not a big deal but I thought you should know

Screenshot_20240505-112932.png

Screenshot_20240505-112906.png

Pixel 7a on firefox

It's been fixed, just waiting to merge: #294

@MRandl
Copy link

MRandl commented May 5, 2024

Oh I didn't know. Sorry to have bothered!

@Tritlo
Copy link
Collaborator

Tritlo commented May 5, 2024

Oh I didn't know. Sorry to have bothered!

No, it's good. I thought it was only on iOS, seems like it is for all mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.