-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logo option UwU #292
Add Logo option UwU #292
Conversation
Could someone explain what this is about? I don't understand. |
@tomjaguarpaw Someone made cute alternative logos of projects: https://github.com/SAWARATSUKI/ServiceLogos Some of them are already using them. That being said since offering the logo from a third-party person is not a trivial matter I'd feel better if the committee would vote on this. |
@tomjaguarpaw It's basically a meme. Feel free to close this if this does not align well with the project. |
What's the license associated this logo? Fun and lighthearted memes like this seem fine, very low risk, and a nice little social media opportunity - if the logo is permissive licensed. Dealing with any license obligations just for this seems unnecessary though. |
I agree, I think it would be fun. The license is CC BY-NC-SA, so we should be good: https://github.com/SAWARATSUKI/ServiceLogos?tab=readme-ov-file#license. I suggest we move quickly on this, could be good PR as you say. |
I don't disagree with including the logo, I just want to focus on maintainability of the code. :) |
Given the general importance of logos/trade marks, I suggest that this is not merged until the Haskell.org Committee and/or the board of directors of Haskell.org, Inc. have had a chance to consider the implications of doing so.EDIT: The board of directors next meets on 9 May 2024, so that would not introduce a long delay. |
The "collaborators" here are the committee 😄 But I agree, we should have consensus. @rebeccaskinner, @aaronallen8455, @angerman, thoughts? I think it's OK, particularly since it is only enabled if you pass a specific string during the request. If React feels comfortable with it, I think we should be OK too. |
One thing I would like the Haskell.org Committee to reflect upon is the use of the 'bag of money' iconography in the image. As far as I can see, none of the other examples has something similar. Also, I do not read Japanese. Is there any perceived meaning to the Japanese characters included in the image? EDIT: I've answered this question: Google Translate tells me ハスケル reads 'Haskell'. |
That's a good point. I'll tweak it and remove the moneybag. |
It would make more sense to replace the bag with (This comment is in no way an endorsement;) |
@Tritlo, on your tweak, which leaves a gap, I would have no anxiety about any |
Hmm yes, but the React and Hono logos have no emojis at all. I thought to keep it simple. |
Alright! I updated it again, moving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change uwu to alternative-logo in the CSS.
Co-authored-by: Hécate Moonlight <[email protected]>
Really wasn't intending to yuck anyone's yum. If this is reverted after some short period of time (I don't see anything suggesting that it would be above this comment, so I don't think it was terribly out of pocket for me to think that this was intended to stick around long-term), I have no objection. |
It would most certainly be temporary. This is in no way a permanent alternative logo, and I don't believe it was suggested as such. |
Huh, why is this 'uwu'? Sorry that I am missing a lot. |
The repo and the original images (and licenses) have disappeared. I'm afraid this is going to be blocked until we can reliably get a source and license for the images. Also I wonder what motivated the deletion of the repo. |
The logos will come back soon with I presume a more open license, I think the repo will be this: https://github.com/SAWARATSUKI/Logos (empty for now) |
I don't have a strong opinion but I'm generally in favor of this as long as the licensing isn't an issue. The edit that @Tritlo made addresses my main complaint with the logo, although I think the purple drop shadow effect doesn't work well with the image placed on a white background. Maybe if the logo used a slightly off-white color then it would look better with the white background of the site (perhaps the same shade of grey that is used for the code example box). Alternatively, the drop shadow could be edited out. |
I am the creator of the logo If the official uses it, you are free to use it for anything, including commercial use!🫠 |
I'm not opposed to this. I did see the one with the money bag before and found that a bit questionable too. But the current one, I have no objections to. We all need a bit of fun in life. ✌️ |
I only used 💰 because I remembered hearing from a friend that Haskell is used in banking and added it. |
I am considering to start using (💰) :: (a -> b) -> a -> b
(💰) = ($)
(◀💰▶) :: Functor f => (a -> b) -> f a -> f b
(◀💰▶) = (<$>) from now on 👿 |
@Kleidukos if we have written permission from the author of the logos to use the modified version is there a reason to keep holding this? 👀 |
We still need a green light from @rebeccaskinner and @tomjaguarpaw. Are you ok with this? |
I'm going to abstain. I still don't really understand what this is. |
Haskell: Avoid fun at all cost just merge this already! :D |
I just wanted to chime in and say that this logo is all kinds of awesome. Great work. |
If you're going to make another operator, you might try flipping the associativity, along with an appropriate (💰!) for strict application.
and say which ones you want to apply strictly, and . still works, so now the . vs $ debate goes away, as there is now a canonical choice. That said, having built a language that used it that way, I er.. eventually relented and switched back because the muscle memory was too strong for the other meaning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the meme, but I'm happy for haskell.org to participate in a fun thing and this seems harmless.
Tested this with javascript enabled and disabled on Firefox and Chromium, didn't see any adverse impact and it looks straightforward.
Seems like we have consensus! @Kleidukos, are you satisfied with the licensing after the written permission? I'll integrate the drop-shadow @aaronallen8455, and do one last test on whether we need the try-catch for localstorage for some permission configurations. |
(I need you to approve the changes in the GitHub interface also) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It's up! Thanks everyone. |
Official announcement: https://discourse.haskell.org/t/cute-alternative-logo-for-haskell-org/9473 |
It's been fixed, just waiting to merge: #294 |
Oh I didn't know. Sorry to have bothered! |
No, it's good. I thought it was only on iOS, seems like it is for all mobile. |
Overview
Adds a query param to switch the Haskell logo to https://github.com/SAWARATSUKI/ServiceLogos:
?uwu=true
?uwu=false
Setting will persist until you turn it off.
Screen
Credits
Credit to @SAWARATSUKI in https://github.com/SAWARATSUKI/ServiceLogos
Context