kv patch command #4432
Merged
kv patch command #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
approved these changes
Apr 23, 2018
command/kv_patch.go
Outdated
| } | ||
|
|
||
| func (c *KVPatchCommand) Synopsis() string { | ||
| return "Sets or updates data in the KV store without ovewriting." |
command/kv_patch.go
Outdated
| type KVPatchCommand struct { | ||
| *BaseCommand | ||
|
|
||
| flagCAS int |
There was a problem hiding this comment.
I don't think this is getting used anywhere. I wonder if we should allow a cas flag that verifies the retrieved version equals that flag
There was a problem hiding this comment.
We could, although in that case you might as well have just modified the output of that initial read. Could defer until someone asks.
There was a problem hiding this comment.
True, i'm fine with that
briankassouf
added a commit
that referenced
this pull request
Apr 23, 2018
* Update kv command to use a preflight check * Make the existing ui endpoint return the allowed mounts * Add kv subcommand tests * Enable `-field` in `vault kv get/put` (#4426) * Enable `-field` in `vault kv get/put` Fixes #4424 * Unify nil value handling * Use preflight helper * Update vkv plugin * Add all the mount info when authenticated * Add fix the error message on put * add metadata test * No need to sort the capabilities * Remove the kv client header * kv patch command (#4432) * Fix test * Fix tests * Use permission denied instead of entity disabled
truenorthcreative
pushed a commit
that referenced
this pull request
Apr 23, 2018
* Update kv command to use a preflight check * Make the existing ui endpoint return the allowed mounts * Add kv subcommand tests * Enable `-field` in `vault kv get/put` (#4426) * Enable `-field` in `vault kv get/put` Fixes #4424 * Unify nil value handling * Use preflight helper * Update vkv plugin * Add all the mount info when authenticated * Add fix the error message on put * add metadata test * No need to sort the capabilities * Remove the kv client header * kv patch command (#4432) * Fix test * Fix tests * Use permission denied instead of entity disabled
This was referenced Apr 23, 2018
|
👏 |
kalafut
reviewed
Apr 25, 2018
|
|
||
| func (c *KVPatchCommand) Help() string { | ||
| helpText := ` | ||
| Usage: vault kv put [options] KEY [DATA] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.