Kv preflight #4430
Merged
Kv preflight #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Apr 23, 2018
command/kv_put.go
Outdated
| @@ -97,14 +97,19 @@ func (c *KVPutCommand) Run(args []string) int { | |||
| stdin = c.testStdin | |||
| } | |||
|
|
|||
| if len(args) < 1 { | |||
| switch { | |||
| case len(args) < 1: | |||
| c.UI.Error(fmt.Sprintf("Not enough arguments (expected 1, got %d)", len(args))) | |||
There was a problem hiding this comment.
This "expected 1" isn't true anymore, because if they provide 1 they hit the next error case.
calvn
reviewed
Apr 23, 2018
| return nil, err | ||
| } | ||
| if entity != nil && entity.Disabled { | ||
| return nil, logical.ErrPermissionDenied |
There was a problem hiding this comment.
Should this return logical.ErrEntityDisabled instead?
There was a problem hiding this comment.
I was trying not to use different error message so as not to leak what mounts exist. And i wanted the ACL check to happen after making sure it's a valid mount
jefferai
approved these changes
Apr 23, 2018
truenorthcreative
pushed a commit
that referenced
this pull request
Apr 23, 2018
* Update kv command to use a preflight check * Make the existing ui endpoint return the allowed mounts * Add kv subcommand tests * Enable `-field` in `vault kv get/put` (#4426) * Enable `-field` in `vault kv get/put` Fixes #4424 * Unify nil value handling * Use preflight helper * Update vkv plugin * Add all the mount info when authenticated * Add fix the error message on put * add metadata test * No need to sort the capabilities * Remove the kv client header * kv patch command (#4432) * Fix test * Fix tests * Use permission denied instead of entity disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.