Enable -field in vault kv get/put
#4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Apr 23, 2018
command/util.go
Outdated
| return 1 | ||
| } | ||
| case map[string]interface{}: | ||
| val = data.(map[string]interface{})[field] |
There was a problem hiding this comment.
Missing an ok check in here?
There was a problem hiding this comment.
I mean wrt accessing the [field] value in the data map. If the provided key doesn't exists, val will be the zero value (not sure what that would for interface{}).
There was a problem hiding this comment.
I think I see what you meant, not the conversion but the field lookup. Check the follow-up commit.
calvn
approved these changes
Apr 23, 2018
briankassouf
approved these changes
Apr 23, 2018
briankassouf
added a commit
that referenced
this pull request
Apr 23, 2018
* Update kv command to use a preflight check * Make the existing ui endpoint return the allowed mounts * Add kv subcommand tests * Enable `-field` in `vault kv get/put` (#4426) * Enable `-field` in `vault kv get/put` Fixes #4424 * Unify nil value handling * Use preflight helper * Update vkv plugin * Add all the mount info when authenticated * Add fix the error message on put * add metadata test * No need to sort the capabilities * Remove the kv client header * kv patch command (#4432) * Fix test * Fix tests * Use permission denied instead of entity disabled
truenorthcreative
pushed a commit
that referenced
this pull request
Apr 23, 2018
* Update kv command to use a preflight check * Make the existing ui endpoint return the allowed mounts * Add kv subcommand tests * Enable `-field` in `vault kv get/put` (#4426) * Enable `-field` in `vault kv get/put` Fixes #4424 * Unify nil value handling * Use preflight helper * Update vkv plugin * Add all the mount info when authenticated * Add fix the error message on put * add metadata test * No need to sort the capabilities * Remove the kv client header * kv patch command (#4432) * Fix test * Fix tests * Use permission denied instead of entity disabled
|
I was thinking because of this ticket it wouldbe possible to replace a single field at a secret path, but when I attempt to use vault kv put with -field it doesn't seem to work in vault 1.5.5 I couldn't see any documentation on being able to use kv put with field so these were all my best guesses about what operation of that might be like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4424