UI: better calculation for advanced secret in KV v2 #24513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
There was a problem hiding this comment.
do we need a test accounting for escape characters/multi line entries \? I remember this coming up somewhere 🤔
hellobontempo
approved these changes
Dec 13, 2023
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24308 we inadvertently introduced an issue where secrets with values that include
{would be locked to the JSON view. This PR makes the check in a more intelligent way so that the original intended behavior is preserved, but secret values are not shown.Now, string values with
{are shown as inputs instead of with the JSON editor:Out of scope for this backport but as a future improvement, we will add obscurity to the JSON view that is toggleable