Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due to [GH-24290] an Vault entry that does include a { will only be displayed as json #24565

Closed
ntap-jbo opened this issue Dec 18, 2023 · 1 comment

Comments

@ntap-jbo
Copy link

Describe the bug
Before Vault Version 1.15.4 an entry could be displayed as either json or non json.
This has been changed since:
https://github.com/hashicorp/vault/blob/main/CHANGELOG.md#1154
ui: When Kv v2 secret is an object, fix so details view defaults to readOnly JSON editor. [GH-24290]
Because of this we have an issue. When for instance password includes a { the output via the web is always shown as json.
Therefore a copy paste of a password is not possible any more, the same not complicated was as before.

We would prefer:

  1. That you can always force the selection, maybe make it optional via a configuration option.
  2. To improve the json detection.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a password with a {
  2. Look at the website
  3. The entry has json enabled and it cant be disabled.

Expected behavior
Either json can still be disabled and/or the json detection is better so this won't happen.
It would always be better that the format can always be changed by the user. Or to have an option in the configuration file that can overrule this option?

Environment:

  • Vault Server Version: 1.15.4

This issue is quite urgent as the web interface is often used.

@marcboudreau
Copy link
Contributor

Hi 👋 @ntap-jbo,

Thank you for taking the time to bring this to our attention. This issue was recently raised and a fix to revert the behaviour has been made that will appear in the next release of Vault (version 1.16.0) and the next update of the 1.15.x version (1.15.5).

Also, in the 1.16.x release, an improvement has also been made that will allow hiding and revealing the JSON editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants