Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.15.x: For showing JSON editor for complex secret in KV details view #24308

Merged
merged 10 commits into from
Dec 4, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Nov 30, 2023

Having fun backport times, so I'm individually running the changes in separate commits.

Backport for this PR

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 30, 2023
Copy link

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip added the ui label Nov 30, 2023
@Monkeychip Monkeychip added this to the 1.15.4 milestone Nov 30, 2023
@Monkeychip Monkeychip marked this pull request as ready for review November 30, 2023 20:07
@Monkeychip Monkeychip enabled auto-merge (squash) November 30, 2023 20:10
Copy link

github-actions bot commented Nov 30, 2023

Build Results:
All builds succeeded! ✅

@@ -1,3 +1,8 @@
{{!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we backport these? I can't remember how that conversation resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we backport them.

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Monkeychip Monkeychip merged commit f42d508 into release/1.15.x Dec 4, 2023
63 checks passed
@Monkeychip Monkeychip deleted the ui/manual-backport-pr-24290-1.1.5.x branch December 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants