UI/add managed ns redirect prefix #14422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce is passed instead, with tests
Monkeychip
reviewed
Mar 9, 2022
| @@ -50,4 +50,32 @@ module('Acceptance | Enterprise | Managed namespace root', function (hooks) { | |||
| 'Correctly prepends root to namespace' | |||
| ); | |||
| }); | |||
|
|
|||
| test('getManagedNamespace helper works as expected', function (assert) { | |||
There was a problem hiding this comment.
Thanks for adding the test coverage!
Monkeychip
approved these changes
Mar 9, 2022
This was referenced Mar 10, 2022
hashishaw
added a commit
that referenced
this pull request
Mar 10, 2022
* The UI redirects to properly prefixed namespace if some other namespace is passed instead, with tests * Fix ordering * Add changelog
hashishaw
added a commit
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the namespace redirect logic on managed vault clusters.
Previous behavior caused a bug where if a namespace was provided in the URL but did not match the required format for managed clusters, it looked like you were logging into the
adminnamespace when in reality, the namespace passed to all requests is whatever is in the URL param.UI Behavior when I try to log in with my token which is valid for the
adminnamespace:Fails because request has the namespace which is in the URL param:
After this fix, whatever namespace passed is parsed and either appended to the root (
admin) or kept as is, if the namespace param starts withadmin/New Behavior
