Backport of UI/add managed ns redirect prefix into release/1.10.x #14436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/add-managed-ns-redirect-prefix/wholly-causal-spider
branch
from
5469128 to
1409670
Compare
hashishaw
approved these changes
Mar 10, 2022
…t-prefix/wholly-causal-spider
hellobontempo
approved these changes
Mar 10, 2022
@hellobontempo yes that's exactly right! |
hashishaw
deleted the
backport/ui/add-managed-ns-redirect-prefix/wholly-causal-spider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14422 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
The below text is copied from the body of the original PR.
This PR updates the namespace redirect logic on managed vault clusters.
Previous behavior caused a bug where if a namespace was provided in the URL but did not match the required format for managed clusters, it looked like you were logging into the
adminnamespace when in reality, the namespace passed to all requests is whatever is in the URL param.UI Behavior when I try to log in with my token which is valid for the
adminnamespace:Fails because request has the namespace which is in the URL param:
After this fix, whatever namespace passed is parsed and either appended to the root (
admin) or kept as is, if the namespace param starts withadmin/New Behavior
