Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI/add managed ns redirect prefix into release/1.9.x #14440

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

hashishaw
Copy link
Contributor

Backport of #14422

* The UI redirects to properly prefixed namespace if some other namespace is passed instead, with tests

* Fix ordering

* Add changelog
@hashishaw hashishaw added ui backport bug Used to indicate a potential bug labels Mar 10, 2022
@hashishaw hashishaw added this to the 1.9.5 milestone Mar 10, 2022
@@ -10,6 +10,16 @@ import ModelBoundaryRoute from 'vault/mixins/model-boundary-route';

const POLL_INTERVAL_MS = 10000;

export const getManagedNamespace = (nsParam, root) => {
if (!nsParam || nsParam.replaceAll('/', '') === root) return root;
// Check if param starts with root and /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 your comments!

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice job!

@hashishaw hashishaw merged commit f9539d4 into release/1.9.x Mar 10, 2022
@hashishaw hashishaw deleted the ui/backport-pr-14422-1.9.x branch March 10, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants