Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source channel with metadata on hcp_aws_network_peering #213

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Oct 22, 2021

🛠️ Description

In testing out #197, I realized it would be useful to also have the module_name set on the hcp_aws_network_peering. That totally skipped my mind when reviewing the previous PR.

🚢 Release Note

Release note for CHANGELOG:

NONE

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run TestAccHvnPeering'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run TestAccHvnPeering -timeout 120m
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccHvnPeering
--- PASS: TestAccHvnPeering (225.32s)
=== RUN   TestAccHvnPeeringConnection
--- PASS: TestAccHvnPeeringConnection (115.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	341.279s

@xargs-P
Copy link
Contributor

xargs-P commented Oct 22, 2021

Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@crhino crhino merged commit 094494d into main Oct 26, 2021
@crhino crhino deleted the crhino/aws-peering-metadata branch October 26, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants