add provider meta schema with module_name field #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
force-pushed
the
add-module-to-provider-schema
branch
from
7c35f42 to
9ae6313
Compare
bcmdarroch
force-pushed
the
add-module-to-provider-schema
branch
from
9ae6313 to
7560a3c
Compare
crhino
reviewed
Oct 15, 2021
internal/clients/client.go
Outdated
Comment on lines
101
to
103
| if err != nil { | ||
| diag.FromErr(err) | ||
| } |
There was a problem hiding this comment.
I think you are missing a return here? Unless this is intentional.
There was a problem hiding this comment.
Oh thanks, good catch!
crhino
approved these changes
Oct 15, 2021
to be called within a resource, after learning that the providerMeta is only available within the context of a resource, not the provider itself.
bcmdarroch
force-pushed
the
add-module-to-provider-schema
branch
from
7560a3c to
942ccf0
Compare
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR adds the ProviderMeta schema block to the provider config. This includes the optional field
module_name, which will be added to a user agent used by analytics.Also adds a helper that handles getting the ProviderMeta in a resource and adds the module name to the user agent. This helper must be added to each resource individually. It currently lives in the Consul cluster, HVN peering, and HVN route.
🚢 Release Note
Release note for CHANGELOG:
🏗️ Acceptance tests
Output from acceptance testing: