Use HCP provider metadata to track module usage #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently in the EKS module the "aws configmap" depends on the variables passed in.
|
I ran the tests for both examples and they passed, plus validated that the metadata was sent correctly. I did realize we should update the provider to add the metadata on the AWS peering connection as well: hashicorp/terraform-provider-hcp#213. |
chapmanc
approved these changes
Oct 22, 2021
| } | ||
| } | ||
|
|
||
| provider_meta "hcp" { | ||
| module_name = "hcp-consul" |
There was a problem hiding this comment.
Should this be even more fine grained? Like hcp-consul-ec2 ?
There was a problem hiding this comment.
Looks like source channel would be terraform-module/hcp-consul-ec2
There was a problem hiding this comment.
Good question! I think for now using just hcp-consul is good enough, and is more consistent with the actual name of the module. If we wanted to track EC2-specific usage, I think a better way would be instrumenting the hcp-ec2-client submodule somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the feature added in hashicorp/terraform-provider-hcp#197 to track module usage.
Also removes test code that was causing failures.