Switch to using golangci-lint instead of go-metalinter #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
paddycarver
added a commit
to GoogleCloudPlatform/magic-modules
that referenced
this pull request
Feb 14, 2019
A whole slew of errors reported by golangci-lint are fixed in this PR. To whit: * Unchecked errors are now checked. * When the DELETE URL is overriden, we have a debug log line to get around the ineffassign linter's complaints about it. We shoudl eventually just only generate the URL we actually need, but this fixes the problem for the moment. * Removed a TODO sanity check override, because the bog that broke it was, I believe, fixed years ago. * Fixed a subtle error shadowing bug in the delete for instance group managers. * Stopped populating the unused "locations" variable in container_cluster's Delete method. * Ignored unused return values instead of populating them. The effect of these changes is that our linter should pass (once the linter is updated in tpg and tpgb, see hashicorp/terraform-provider-google#3049 and hashicorp/terraform-provider-google-beta#437) and we, as a bonus, are handling more error cases and fixed a subtle bug.
|
Travis failed due to lint issues that it previously didn't catch. I filed GoogleCloudPlatform/magic-modules#1387 to resolve all those issues. When that PR is merged, these lint issues will go away. |
rileykarson
approved these changes
Feb 14, 2019
| @@ -6,7 +6,7 @@ language: go | |||
| go: | |||
| - "1.11.x" | |||
| env: | |||
| - GO111MODULE=off | |||
| - GO111MODULE=on | |||
There was a problem hiding this comment.
Same as tpg, can we set GOFLAGS=-mod=vendor?
paddycarver
added a commit
to GoogleCloudPlatform/magic-modules
that referenced
this pull request
Feb 15, 2019
A whole slew of errors reported by golangci-lint are fixed in this PR. To whit: * Unchecked errors are now checked. * When the DELETE URL is overriden, we have a debug log line to get around the ineffassign linter's complaints about it. We shoudl eventually just only generate the URL we actually need, but this fixes the problem for the moment. * Removed a TODO sanity check override, because the bog that broke it was, I believe, fixed years ago. * Fixed a subtle error shadowing bug in the delete for instance group managers. * Stopped populating the unused "locations" variable in container_cluster's Delete method. * Ignored unused return values instead of populating them. The effect of these changes is that our linter should pass (once the linter is updated in tpg and tpgb, see hashicorp/terraform-provider-google#3049 and hashicorp/terraform-provider-google-beta#437) and we, as a bonus, are handling more error cases and fixed a subtle bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the footsteps of our friends working on the AWS provider in hashicorp/terraform-provider-aws#7457 and prompted by go-metalinter's mainainer's stance, we're switching from go-metalinter to golangci-lint. This PR updates the Travis config, makefile, and lint configs to make this happen.