Switch to using golangci-lint instead of go-metalinter #3049
Conversation
A whole slew of errors reported by golangci-lint are fixed in this PR. To whit: * Unchecked errors are now checked. * When the DELETE URL is overriden, we have a debug log line to get around the ineffassign linter's complaints about it. We shoudl eventually just only generate the URL we actually need, but this fixes the problem for the moment. * Removed a TODO sanity check override, because the bog that broke it was, I believe, fixed years ago. * Fixed a subtle error shadowing bug in the delete for instance group managers. * Stopped populating the unused "locations" variable in container_cluster's Delete method. * Ignored unused return values instead of populating them. The effect of these changes is that our linter should pass (once the linter is updated in tpg and tpgb, see hashicorp/terraform-provider-google#3049 and hashicorp/terraform-provider-google-beta#437) and we, as a bonus, are handling more error cases and fixed a subtle bug.
|
Travis failed due to lint issues that it previously didn't catch. I filed GoogleCloudPlatform/magic-modules#1387 to resolve all those issues. When that PR is merged, these lint issues will go away. |
|
Fixes #3014. |
| @@ -6,7 +6,7 @@ language: go | |||
| go: | |||
| - "1.11.x" | |||
| env: | |||
| - GO111MODULE=off | |||
| - GO111MODULE=on | |||
There was a problem hiding this comment.
Can you see if we're able to safely set GOFLAGS=-mod=vendor as well?
There was a problem hiding this comment.
I believe it's unnecessary, as the linting tool does it automatically?
There was a problem hiding this comment.
Oh not for the linting tool, just because Go will realise we're using vendored modules in that case.
A whole slew of errors reported by golangci-lint are fixed in this PR. To whit: * Unchecked errors are now checked. * When the DELETE URL is overriden, we have a debug log line to get around the ineffassign linter's complaints about it. We shoudl eventually just only generate the URL we actually need, but this fixes the problem for the moment. * Removed a TODO sanity check override, because the bog that broke it was, I believe, fixed years ago. * Fixed a subtle error shadowing bug in the delete for instance group managers. * Stopped populating the unused "locations" variable in container_cluster's Delete method. * Ignored unused return values instead of populating them. The effect of these changes is that our linter should pass (once the linter is updated in tpg and tpgb, see hashicorp/terraform-provider-google#3049 and hashicorp/terraform-provider-google-beta#437) and we, as a bonus, are handling more error cases and fixed a subtle bug.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Following in the footsteps of our friends working on the AWS provider in hashicorp/terraform-provider-aws#7457 and prompted by go-metalinter's mainainer's stance, we're switching from go-metalinter to golangci-lint. This PR updates the Travis config, makefile, and lint configs to make this happen.