Skip to content

Commit

Permalink
Switch to using golangci-lint instead of go-metalinter (#437)
Browse files Browse the repository at this point in the history
* Use golangci-lint instead of gometalinter.

* Set go flags to vendor.
  • Loading branch information
paddycarver authored Feb 15, 2019
1 parent 63f47d3 commit b55c062
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 6 deletions.
26 changes: 26 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
issues:
max-per-linter: 0
max-same-issues: 0

linters:
disable-all: true
enable:
- deadcode
- errcheck
- gofmt
- gosimple
- ineffassign
- misspell
- staticcheck
- structcheck
- unconvert
- unused
- varcheck
- vet

linters-settings:
errcheck:
ignore: github.com/hashicorp/terraform/helper/schema:ForceNew|Set,fmt:.*,io:Close,github.com/terraform-providers/terraform-provider-google-beta/google-beta:Set

run:
modules-download-mode: vendor
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ language: go
go:
- "1.11.x"
env:
- GO111MODULE=off
- GO111MODULE=on
GOFLAGS=-mod=vendor

install:
# This script is used by the Travis build to install a cookie for
Expand All @@ -24,7 +25,6 @@ script:
branches:
only:
- master
- 2.0.0
matrix:
fast_finish: true
allow_failures:
Expand Down
8 changes: 4 additions & 4 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ fmtcheck:

lint:
@echo "==> Checking source code against linters..."
@bash -c "GO111MODULE=off gometalinter -d ./... 2> >(egrep '(^DEBUG.*linter took|^DEBUG.*total elapsed|^[^D])' >&2)"
@golangci-lint run ./$(DIR_NAME)

tools:
@echo "==> installing required tooling..."
GO111MODULE=off go get -u github.com/alecthomas/gometalinter
GO111MODULE=off gometalinter --install
GO111MODULE=off go get -u github.com/client9/misspell/cmd/misspell
GO111MODULE=off go get -u github.com/golangci/golangci-lint/cmd/golangci-lint

test-compile:
@if [ "$(TEST)" = "./..." ]; then \
echo "ERROR: Set TEST to a specific package. For example,"; \
echo " make test-compile TEST=./$(PKG_NAME)"; \
echo " make test-compile TEST=./$(DIR_NAME)"; \
exit 1; \
fi
go test -c $(TEST) $(TESTARGS)
Expand Down

0 comments on commit b55c062

Please sign in to comment.