Skip instance migrate tests, they handle config directly #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Skip instance migrate tests, they handle config directly * Skip vcr for bigquery, it uses a client factory to produce new http clients on demand rather than using the shared client * Add note on bigtable instance Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-217d0bedeb5ffde86b193dc6022802f52f166dad
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because these tests don't use
resource.Testand instead manually create*Configobjects they never properly call theConfigureFuncon the config, preventing VCR transport swappingSkip Bigtable tests that use a client factory that takes the raw TokenSource to produce new clients on demand within the resource rather than using the shared HTTP client
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3554