-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip instance migrate tests, they handle config directly #3554
Skip instance migrate tests, they handle config directly #3554
Conversation
@@ -8,6 +8,8 @@ import ( | |||
) | |||
|
|||
func TestAccBigtableAppProfile_update(t *testing.T) { | |||
// bigtable does not use the shared HTTP client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you also need a skip on the app profile generated tests?
(also the comment is mostly true, but this resource and the IAM ones I think do use the shared HTTP client, it's just that their tests also create instances, which don't)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, app profile tests set up an instance. I'll change the note to reference the bigtable instance only
…lients on demand rather than using the shared client
6cef13d
to
043fab0
Compare
Because these tests don't use
resource.Test
and instead manually create*Config
objects they never properly call theConfigureFunc
on the config, preventing VCR transport swappingSkip Bigtable tests that use a client factory that takes the raw TokenSource to produce new clients on demand within the resource rather than using the shared HTTP client
Release Note Template for Downstream PRs (will be copied)