Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip instance migrate tests, they handle config directly #2112

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3554.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
2 changes: 2 additions & 0 deletions google-beta/resource_bigtable_app_profile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
)

func TestAccBigtableAppProfile_update(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down
4 changes: 4 additions & 0 deletions google-beta/resource_bigtable_gc_policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
)

func TestAccBigtableGCPolicy_basic(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -33,6 +35,8 @@ func TestAccBigtableGCPolicy_basic(t *testing.T) {
}

func TestAccBigtableGCPolicy_union(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down
6 changes: 6 additions & 0 deletions google-beta/resource_bigtable_instance_iam_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
)

func TestAccBigtableInstanceIamBinding(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instance := "tf-bigtable-iam-" + randString(t, 10)
Expand Down Expand Up @@ -51,6 +53,8 @@ func TestAccBigtableInstanceIamBinding(t *testing.T) {
}

func TestAccBigtableInstanceIamMember(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instance := "tf-bigtable-iam-" + randString(t, 10)
Expand Down Expand Up @@ -89,6 +93,8 @@ func TestAccBigtableInstanceIamMember(t *testing.T) {
}

func TestAccBigtableInstanceIamPolicy(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instance := "tf-bigtable-iam-" + randString(t, 10)
Expand Down
8 changes: 8 additions & 0 deletions google-beta/resource_bigtable_instance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
)

func TestAccBigtableInstance_basic(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down Expand Up @@ -47,6 +49,8 @@ func TestAccBigtableInstance_basic(t *testing.T) {
}

func TestAccBigtableInstance_cluster(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down Expand Up @@ -101,6 +105,8 @@ func TestAccBigtableInstance_cluster(t *testing.T) {
}

func TestAccBigtableInstance_development(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -124,6 +130,8 @@ func TestAccBigtableInstance_development(t *testing.T) {
}

func TestAccBigtableInstance_allowDestroy(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down
10 changes: 10 additions & 0 deletions google-beta/resource_bigtable_table_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
)

func TestAccBigtableTable_basic(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -33,6 +35,8 @@ func TestAccBigtableTable_basic(t *testing.T) {
}

func TestAccBigtableTable_splitKeys(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -57,6 +61,8 @@ func TestAccBigtableTable_splitKeys(t *testing.T) {
}

func TestAccBigtableTable_family(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -81,6 +87,8 @@ func TestAccBigtableTable_family(t *testing.T) {
}

func TestAccBigtableTable_familyMany(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand All @@ -105,6 +113,8 @@ func TestAccBigtableTable_familyMany(t *testing.T) {
}

func TestAccBigtableTable_familyUpdate(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
skipIfVcr(t)
t.Parallel()

instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
Expand Down
2 changes: 2 additions & 0 deletions google-beta/resource_compute_instance_migrate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,8 @@ func cleanUpDisk(config *Config, diskName, zone string) {
}

func getInitializedConfig(t *testing.T) *Config {
// Migrate tests are non standard and handle the config directly
skipIfVcr(t)
// Check that all required environment variables are set
testAccPreCheck(t)

Expand Down