-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credential library resource for Vault #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is going in the right direction.
@malnick PTAL I exposed NewVaultTestServer in this PR hashicorp/boundary#1321 |
bab14bc
to
3fafc4c
Compare
Just FYI I have now added the target cred lib Set functionality and associated tests...tests are all going green now, would be good to get a review so we can have this PR ready to merge once vault work merges to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
if len(opts) > 0 { | ||
opts = append(opts, credentialstores.WithAutomaticVersioning(true)) | ||
aur, err := client.Update(ctx, d.Id(), 0, opts...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If aur has a different value for credentialStoreVaultTokenHmacKey than we have stored we should issue another update just on the token or maybe we should issue a read before the update. Same thing for the clientCertificate Key. Please also add a test for this.
Just a note that this PR is ready to go but we're waiting to rebase the go.mod on Relies on hashicorp/boundary#1308 being merged to |
18fcc98
to
244e8a6
Compare
244e8a6
to
ac41548
Compare
* docs: update host catalog resource with correct value for type attribute * build: add Makefile target for auto-generating docs * bugfix: make OIDC account attribute for subject ForceNew * docs: update auto-generated docs * Add credential library resource for Vault (#114) * Integrate with Vault to retrieve and manage per session credentials Co-authored-by: Louis Ruch <[email protected]> * Update token/clientKey on hmac change (#125) * Update token/clientKey on hmac change * Update changelog * Update docs * Prep for 1.0.3 * v1.0.3 * Update terraform-plugin-sdk * Fix Typo * Adopt American spelling * fix the parameter that is actually being sent as the auth method id Co-authored-by: Jeff Malnick <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]>
* feat: add managed group resource * feat: add tests for managed group resource * update go.sum * update tests * simplify the managed group resource * use WithDefaultPasswordAuthMethodId * Managed groups (#129) * docs: update host catalog resource with correct value for type attribute * build: add Makefile target for auto-generating docs * bugfix: make OIDC account attribute for subject ForceNew * docs: update auto-generated docs * Add credential library resource for Vault (#114) * Integrate with Vault to retrieve and manage per session credentials Co-authored-by: Louis Ruch <[email protected]> * Update token/clientKey on hmac change (#125) * Update token/clientKey on hmac change * Update changelog * Update docs * Prep for 1.0.3 * v1.0.3 * Update terraform-plugin-sdk * Fix Typo * Adopt American spelling * fix the parameter that is actually being sent as the auth method id Co-authored-by: Jeff Malnick <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]> * nits and updates * OIDC auth method + get filter from attributes * Add changelog * Fix schema description Co-authored-by: Riley Guerin <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]>
Adds the credential library resource for Vault:
Built on https://github.com/hashicorp/boundary/tree/mgaffney-vault