Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose NewVaultTestServer #1321

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Expose NewVaultTestServer #1321

merged 2 commits into from
Jun 15, 2021

Conversation

louisruch
Copy link
Collaborator

No description provided.

@louisruch
Copy link
Collaborator Author

@mgaffney The controller package in testing did a similar method for exposing NewTestController I have made a number of changes to the tf provider to verify this is working as well

@louisruch louisruch requested a review from malnick June 12, 2021 23:56
@louisruch louisruch mentioned this pull request Jun 12, 2021
Merged
malnick
malnick approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@malnick malnick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass on this and it looks good. If we could merge this to mgaffney-vault, then I would not need to manage my own compound branch that includes this and the former branch while doing provider development.

Out of overwhelming laziness, I didn't test this, but it should be easy enough to merge in a patch if we need it.

@louisruch
Copy link
Collaborator Author

First pass on this and it looks good. If we could merge this to mgaffney-vault, then I would not need to manage my own compound branch that includes this and the former branch while doing provider development.

Out of overwhelming laziness, I didn't test this, but it should be easy enough to merge in a patch if we need it.

Make sure to pull your TF provider branch I made a number of changes yesterday.

@louisruch louisruch merged commit 2405885 into mgaffney-vault Jun 15, 2021
@louisruch louisruch deleted the louis-vault-server branch June 15, 2021 20:32
hugoghx pushed a commit that referenced this pull request Dec 6, 2024
@moduli
test(e2e): Fix certificate injection test (#1321)
3cfec53 
* test(e2e): Fix certificate injection test

Modifications to the test were needed due to some directory changes to the openssh server docker container.

* CR

* CR: change cp to mv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malnick malnick malnick approved these changes

@talanknight talanknight talanknight approved these changes

@mgaffney mgaffney Awaiting requested review from mgaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louisruch @talanknight @malnick