generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update token/clientKey on hmac change #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisruch
force-pushed
the
louis-token-update
branch
from
June 24, 2021 23:48
6a6f7bd
to
373e5db
Compare
@talanknight @malnick PTAL |
malnick
approved these changes
Jun 25, 2021
* Adds claim scopes attribute to OIDC auth method | ||
([PR](https://github.com/hashicorp/terraform-provider-boundary/pull/112)). | ||
* Adds account claim maps attribute to OIDC auth method | ||
([PR](https://github.com/hashicorp/terraform-provider-boundary/pull/111)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including these, completely slipped on my PR for the library and store PR.
talanknight
approved these changes
Jun 25, 2021
louisruch
added a commit
that referenced
this pull request
Aug 16, 2021
* docs: update host catalog resource with correct value for type attribute * build: add Makefile target for auto-generating docs * bugfix: make OIDC account attribute for subject ForceNew * docs: update auto-generated docs * Add credential library resource for Vault (#114) * Integrate with Vault to retrieve and manage per session credentials Co-authored-by: Louis Ruch <[email protected]> * Update token/clientKey on hmac change (#125) * Update token/clientKey on hmac change * Update changelog * Update docs * Prep for 1.0.3 * v1.0.3 * Update terraform-plugin-sdk * Fix Typo * Adopt American spelling * fix the parameter that is actually being sent as the auth method id Co-authored-by: Jeff Malnick <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]>
louisruch
added a commit
that referenced
this pull request
Aug 17, 2021
* feat: add managed group resource * feat: add tests for managed group resource * update go.sum * update tests * simplify the managed group resource * use WithDefaultPasswordAuthMethodId * Managed groups (#129) * docs: update host catalog resource with correct value for type attribute * build: add Makefile target for auto-generating docs * bugfix: make OIDC account attribute for subject ForceNew * docs: update auto-generated docs * Add credential library resource for Vault (#114) * Integrate with Vault to retrieve and manage per session credentials Co-authored-by: Louis Ruch <[email protected]> * Update token/clientKey on hmac change (#125) * Update token/clientKey on hmac change * Update changelog * Update docs * Prep for 1.0.3 * v1.0.3 * Update terraform-plugin-sdk * Fix Typo * Adopt American spelling * fix the parameter that is actually being sent as the auth method id Co-authored-by: Jeff Malnick <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]> * nits and updates * OIDC auth method + get filter from attributes * Add changelog * Fix schema description Co-authored-by: Riley Guerin <[email protected]> Co-authored-by: Louis Ruch <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Lewis Cowper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
The Boundary API does not return the
ClientCertKey
or theToken
in the response, instead it returns an hmac for each of those fields. This PRs updates these fields to(changed in Boundary)
when a change was detected on the corresponding hmac during a read request. This will allow tf to detect theClientCertKey
or theToken
has changed.Please note this will currently fail when changing a
token
back due to outstanding work on Boundary. However, it will at least notify the tf user that there was a change and they should update the tf file to match the current state.This PR also updates:
PR verification steps
Please note because of the outstanding work in Boundary to support changing back to a previously used token, the unit test cannot fully verify the final update back to the tf config. I did however verify the changes to detect token and certKey works by setting
ExpectNonEmptyPlan: false
and running the unit test:Without the changes from this PR the final step fails without the
client_certificate_key
andtoken
detected as diffs: