Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits conforming to Azure docs: https://docs.microsoft.com/en-us/azu… #2806

Closed
wants to merge 0 commits into from
Closed

Conversation

georgespatton
Copy link

@georgespatton georgespatton commented Jan 30, 2019

This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview

Fixes #2624

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @georgespatton,

Thanks for opening this PR. The change LGTM however could we add a test with the capacity block and the properties at 0 is one step and something > 40 in the next?

Thanks!

@katbyte katbyte modified the milestone: 1.22.0 Jan 30, 2019
@ghost ghost added size/M and removed size/XS labels Jan 31, 2019
@georgespatton
Copy link
Author

@katbyte I added a test case, let me know what you think.

@tombuildsstuff tombuildsstuff self-assigned this Jan 31, 2019
@tombuildsstuff
Copy link
Contributor

hey @georgespatton

Thanks for pushing those changes :)

As a part of the v1.22 release we're renaming the azurerm_autoscale_setting resource to azurerm_monitor_autoscale_setting - as such this change will need to be made in both places. So that we can get this merged and released as a part of the v1.22 release - I'm going to push a commit which also makes this change to that resource (and updates the documentation), I hope you don't mind!

Thanks!

@georgespatton
Copy link
Author

Sounds great, thank you!

@ghost ghost added size/XS and removed size/M labels Jan 31, 2019
@tombuildsstuff
Copy link
Contributor

@georgespatton apologies, I don't entirely understand how but I appear to have broken this PR upon pushing the updates to your fork. I hope you don't mind but I'm going to open another PR which includes these commits - you'll still get the credits/attribution for this (since these include your commits) - and this should go out as a part of v1.22 - apologies either way!

tombuildsstuff pushed a commit that referenced this pull request Jan 31, 2019
katbyte pushed a commit that referenced this pull request Feb 7, 2019
Including the changes from @georgespatton in #2806 - pushing to that fork broken the PR 🤷‍♂️

Original PR:

---

This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview

Fixes #2136
Fixes #2624
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants