Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set autoscaling setting for vmss to 0 min/default, also max too low #2624

Closed
slikk66 opened this issue Jan 8, 2019 · 3 comments · Fixed by #2815
Closed

Unable to set autoscaling setting for vmss to 0 min/default, also max too low #2624

slikk66 opened this issue Jan 8, 2019 · 3 comments · Fixed by #2815

Comments

@slikk66
Copy link

slikk66 commented Jan 8, 2019

In the console, I can apply an autoscaling rule to a VMSS and set it to 0 for min/default: https://imgur.com/a/B5WE7i3

Checking resouces.azure.com, this is confirmed:

"properties": {
  "profiles": [
    {
      "name": "Auto created scale condition",
      "capacity": {
        "minimum": "0",
        "maximum": "300",
        "default": "0"
      },

However, trying to do so via Terraform I hit a limit of 1-40, apparently controlled here:
https://github.com/terraform-providers/terraform-provider-azurerm/blob/47a920a9fdd0e8b82d7d7c568caee6b9fb6db410/azurerm/resource_arm_autoscale_setting.go#L74

azure:autoscale:Setting (Stage-Eus2-Scale-Config):
  error: azure:autoscale/setting:Setting resource 'Stage-Eus2-Scale-Config' has a problem: expected profile.0.capacity.0.default to be in the range (1 - 40), got 0                                                                                            
  error: azure:autoscale/setting:Setting resource 'Stage-Eus2-Scale-Config' has a problem: expected profile.0.capacity.0.minimum to be in the range (1 - 40), got 0 

Also, the max is 40.. why on earth? We can have somewhere upwards of 1000 for a vmss.. please fix this!

@slikk66 slikk66 changed the title Unable to set autoscaling setting for vmss to 0 min/default Unable to set autoscaling setting for vmss to 0 min/default, also max too low Jan 8, 2019
@katbyte katbyte added bug service/vmss Virtual Machine Scale Sets labels Jan 9, 2019
@tombuildsstuff tombuildsstuff added service/monitor and removed service/vmss Virtual Machine Scale Sets labels Jan 10, 2019
@georgespatton
Copy link

This is the exact same bug I am seeing here:

#2136

@georgespatton
Copy link

PR pending review here: #2806

@katbyte katbyte added this to the 1.22.0 milestone Feb 7, 2019
katbyte pushed a commit that referenced this issue Feb 7, 2019
Including the changes from @georgespatton in #2806 - pushing to that fork broken the PR 🤷‍♂️

Original PR:

---

This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview

Fixes #2136
Fixes #2624
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants