Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot increase maximum size of Azure VMSS #2136

Closed
georgespatton opened this issue Oct 22, 2018 · 5 comments · Fixed by #2815
Closed

Cannot increase maximum size of Azure VMSS #2136

georgespatton opened this issue Oct 22, 2018 · 5 comments · Fixed by #2815

Comments

@georgespatton
Copy link

georgespatton commented Oct 22, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

I can't increase the size of an existing VMSS within Azure. It was created via terraform originally. I am using the latest version of terraform. I tried the latest version of provider.azurerm (v1.17.0) with the same behavior.

$ terraform plan

Error: module.ourmodule.azurerm_autoscale_setting.vmss-autoscale-cpu: expected profile.0.capacity.0.maximum to be in the range (1 - 40), got 1000

$ terraform -version
Terraform v0.11.9
+ provider.azurerm v1.16.0
+ provider.random v2.0.0


$ git diff
diff --git a/avmss.tf
index 152733e..de42594 100644
--- a/vmss.tf
+++ b/vmss.tf
@@ -91,7 +91,7 @@ resource "azurerm_autoscale_setting" "vmss-autoscale-cpu" {
     capacity {
       default = 10
       minimum = 10
-      maximum = 40
+      maximum = 1000
     }
 
$ cat vmss.tf 

.......

### Configuration for Service azurerm_autoscale_setting ###
##
##
resource "azurerm_autoscale_setting" "prod-autoscale-cpu" {
  name                = "Percentage CPU"
  resource_group_name = "${var.resource_group_name}"
  location            = "${var.location}"
  target_resource_id  = "${azurerm_virtual_machine_scale_set.prod-ss.id}"

  profile {
    name = "Percentage CPU"
    capacity {
      default = 10
      minimum = 10
      maximum = 1000
    }

.........

To reproduce, create an Azure VMSS with terraform with set minimum/maximum/default values. Then increase the maximum setting. It should fail as this does.

@katbyte katbyte added bug service/vmss Virtual Machine Scale Sets labels Oct 25, 2018
@dl888888

This comment has been minimized.

@jgabinet

This comment has been minimized.

@georgespatton
Copy link
Author

Why are we limited to 40 VMSS max instances in the terraform config?

@georgespatton
Copy link
Author

PR pending review here: #2806

@tombuildsstuff tombuildsstuff added service/monitor and removed service/vmss Virtual Machine Scale Sets labels Jan 31, 2019
@katbyte katbyte added this to the 1.22.0 milestone Feb 7, 2019
katbyte pushed a commit that referenced this issue Feb 7, 2019
Including the changes from @georgespatton in #2806 - pushing to that fork broken the PR 🤷‍♂️

Original PR:

---

This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview

Fixes #2136
Fixes #2624
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants