`azurerm_virtual_network_gateway` - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

neil-yechenwei · 2023-09-08T06:23:56Z

This PR is to support new properties bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy for Virtual Network Gateway.

katbyte

LGTM 🌩️

manicminer · 2023-10-12T22:29:28Z

@neil-yechenwei Looks like we have a new test failure, the resource entered a failed state

neil-yechenwei · 2023-10-14T01:48:29Z

@manicminer , after rerun, all related test cases passed.

katbyte

@neil-yechenwei - it looks like there is something flaky here, 2 tests are failing in the last run, a different error here:


------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== PAUSE TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== CONT  TestAccVirtualNetworkGatewayConnection_updatingSharedKey
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for completion of Virtual Network Gateway: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): Code="RetryableError" Message="A retryable error occurred." Details=[{"code":"RetryableErrorDueToAnotherOperation","message":"Operation PutVirtualNetworkGatewayOperation (3c216d95-9fa6-422d-b6fc-2dc3c258ec54) is updating resource *******. The call can be retried in 15 seconds."}]
        
          with azurerm_virtual_network_gateway.test_1,
          on terraform_plugin_test.tf line 57, in resource "azurerm_virtual_network_gateway" "test_1":
          57: resource "azurerm_virtual_network_gateway" "test_1" {
        
    testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Public Ip Address: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): network.PublicIPAddressesClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="PublicIPAddressCannotBeDeleted" Message="Public IP address /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/publicIPAddresses/acctest-231106210457835008 can not be deleted since it is still allocated to resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008/ipConfigurations/vnetGatewayConfig. In order to delete the public IP, disassociate/detach the Public IP address from the resource.  To learn how to do this, see aka.ms/deletepublicip." Details=[]
        
        
        Error: deleting Subnet (Subscription: "*******"
        Resource Group Name: "acctestRG-231106210457835008"
        Virtual Network Name: "acctestvn-231106210457835008"
        Subnet Name: "GatewaySubnet"): network.SubnetsClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="ReferencedResourceNotProvisioned" Message="Cannot proceed with operation because resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008 used by resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworks/acctestvn-231106210457835008/subnets/GatewaySubnet is not in Succeeded state. Resource is in Failed state and the last operation that updated/is updating the resource is PutVirtualNetworkGatewayOperation." Details=[]
        
--- FAIL: TestAccVirtualNetworkGatewayConnection_updatingSharedKey (496.71s)
FAIL

could you please try to account for this in the resource so users don't experience it? running tests till they pass is not acceptable. thanks

katbyte

@neil-yechenwei - it looks like there is something flaky here, 2 tests are failing in the last run, a different error here:


------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== PAUSE TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== CONT  TestAccVirtualNetworkGatewayConnection_updatingSharedKey
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for completion of Virtual Network Gateway: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): Code="RetryableError" Message="A retryable error occurred." Details=[{"code":"RetryableErrorDueToAnotherOperation","message":"Operation PutVirtualNetworkGatewayOperation (3c216d95-9fa6-422d-b6fc-2dc3c258ec54) is updating resource *******. The call can be retried in 15 seconds."}]
        
          with azurerm_virtual_network_gateway.test_1,
          on terraform_plugin_test.tf line 57, in resource "azurerm_virtual_network_gateway" "test_1":
          57: resource "azurerm_virtual_network_gateway" "test_1" {
        
    testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Public Ip Address: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): network.PublicIPAddressesClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="PublicIPAddressCannotBeDeleted" Message="Public IP address /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/publicIPAddresses/acctest-231106210457835008 can not be deleted since it is still allocated to resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008/ipConfigurations/vnetGatewayConfig. In order to delete the public IP, disassociate/detach the Public IP address from the resource.  To learn how to do this, see aka.ms/deletepublicip." Details=[]
        
        
        Error: deleting Subnet (Subscription: "*******"
        Resource Group Name: "acctestRG-231106210457835008"
        Virtual Network Name: "acctestvn-231106210457835008"
        Subnet Name: "GatewaySubnet"): network.SubnetsClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="ReferencedResourceNotProvisioned" Message="Cannot proceed with operation because resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008 used by resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworks/acctestvn-231106210457835008/subnets/GatewaySubnet is not in Succeeded state. Resource is in Failed state and the last operation that updated/is updating the resource is PutVirtualNetworkGatewayOperation." Details=[]
        
--- FAIL: TestAccVirtualNetworkGatewayConnection_updatingSharedKey (496.71s)
FAIL

could you please try to account for this in the resource so users don't experience it? running tests till they pass is not acceptable. thanks

katbyte

@neil-yechenwei - it looks like there is something flaky here, 2 tests are failing in the last run, a different error here:


------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== PAUSE TestAccVirtualNetworkGatewayConnection_updatingSharedKey
=== CONT  TestAccVirtualNetworkGatewayConnection_updatingSharedKey
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for completion of Virtual Network Gateway: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): Code="RetryableError" Message="A retryable error occurred." Details=[{"code":"RetryableErrorDueToAnotherOperation","message":"Operation PutVirtualNetworkGatewayOperation (3c216d95-9fa6-422d-b6fc-2dc3c258ec54) is updating resource *******. The call can be retried in 15 seconds."}]
        
          with azurerm_virtual_network_gateway.test_1,
          on terraform_plugin_test.tf line 57, in resource "azurerm_virtual_network_gateway" "test_1":
          57: resource "azurerm_virtual_network_gateway" "test_1" {
        
    testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Public Ip Address: (Name "acctest-231106210457835008" / Resource Group "acctestRG-231106210457835008"): network.PublicIPAddressesClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="PublicIPAddressCannotBeDeleted" Message="Public IP address /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/publicIPAddresses/acctest-231106210457835008 can not be deleted since it is still allocated to resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008/ipConfigurations/vnetGatewayConfig. In order to delete the public IP, disassociate/detach the Public IP address from the resource.  To learn how to do this, see aka.ms/deletepublicip." Details=[]
        
        
        Error: deleting Subnet (Subscription: "*******"
        Resource Group Name: "acctestRG-231106210457835008"
        Virtual Network Name: "acctestvn-231106210457835008"
        Subnet Name: "GatewaySubnet"): network.SubnetsClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="ReferencedResourceNotProvisioned" Message="Cannot proceed with operation because resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworkGateways/acctest-231106210457835008 used by resource /subscriptions/*******/resourceGroups/acctestRG-231106210457835008/providers/Microsoft.Network/virtualNetworks/acctestvn-231106210457835008/subnets/GatewaySubnet is not in Succeeded state. Resource is in Failed state and the last operation that updated/is updating the resource is PutVirtualNetworkGatewayOperation." Details=[]
        
--- FAIL: TestAccVirtualNetworkGatewayConnection_updatingSharedKey (496.71s)
FAIL

could you please try to account for this in the resource so users don't experience it? running tests till they pass is not acceptable. thanks

neil-yechenwei · 2023-11-07T05:30:41Z

Hi @katbyte , seems your same comment is added three times.

I assume the test prefix in teamcity needs to be set to "TestAccVirtualNetworkGateway_" since I only changed the azurerm_virtual_network_gateway. All related test cases passed in the latest run.
TestAccVirtualNetworkGateway_vpnGw1 can pass after rerun.
Teamcity returns the error that is same with the error in the last daily run with main branch after rerun test case TestAccVirtualNetworkGatewayConnection_updatingSharedKey. As of the error for this test case, I submitted another PR to fix it since it's not related with this PR.

katbyte

LGTM 📨

neil-yechenwei · 2023-12-06T00:03:58Z

@katbyte , is it good to be merge?

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.82.0" to "3.83.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.83.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.83.0
UPGRADE NOTES

* Key Vaults are now loaded using [the `ListBySubscription` API within the Key Vault Resource Provider](https://learn.microsoft.com/en-us/rest/api/keyvault/keyvault/vaults/list-by-subscription?view=rest-keyvault-keyvault-2022-07-01&tabs=HTTP) rather than [the Resources API](https://learn.microsoft.com/en-us/rest/api/keyvault/keyvault/vaults/list?view=rest-keyvault-keyvault-2022-07-01&tabs=HTTP). This change means that the Provider now caches the list of Key Vaults available within a Subscription, rather than loading these piecemeal to workaround stale data returned from the Resources API ([#24019](https://github.com/hashicorp/terraform-provider-azurerm/issues/24019))

FEATURES:

* New Data Source: `azurerm_stack_hci_cluster` ([#24032](https://github.com/hashicorp/terraform-provider-azurerm/issues/24032))

ENHANCEMENTS:

* dependencies: updating to `v0.20231129.1103252` of `github.com/hashicorp/go-azure-sdk` ([#24063](hashicorp/terraform-provider-azurerm#24063 `automation`: updating to API Version `2023-11-01` ([#24017](hashicorp/terraform-provider-azurerm#24017 `keyvault`: the cache is now populated using the `ListBySubscription` endpoint on the KeyVault Resource Provider rather than via the `Resources` API ([#24019](hashicorp/terraform-provider-azurerm#24019 `keyvault`: updating the cache to populate all Key Vaults available within the Subscription to reduce the number of API calls ([#24019](hashicorp/terraform-provider-azurerm#24019 Data Source `azurerm_private_dns_zone`: refactoring to use the `ListBySubscription` API rather than the Resources API when `resource_group_name` is omitted ([#24024](hashicorp/terraform-provider-azurerm#24024 `azurerm_dashboard_grafana` - support for `grafana_major_version` ([#24014](hashicorp/terraform-provider-azurerm#24014 `azurerm_linux_web_app` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_linux_web_app_slot` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_media_transform` - deprecate `face_detector_preset` and `video_analyzer_preset` ([#24002](hashicorp/terraform-provider-azurerm#24002 `azurerm_postgresql_database` - update the validation of `collation` to include `Norwegian_Norway.1252` ([#24070](hashicorp/terraform-provider-azurerm#24070 `azurerm_postgresql_flexible_server` - updating to API Version `2023-06-01-preview` ([#24016](hashicorp/terraform-provider-azurerm#24016 `azurerm_redis_cache` - support for the `active_directory_authentication_enabled` property ([#23976](hashicorp/terraform-provider-azurerm#23976 `azurerm_windows_web_app` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_windows_web_app_slot` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_storage_account` - add `name` validation in custom diff ([#23799](https://github.com/hashicorp/terraform-provider-azurerm/issues/23799))

BUG FIXES:

* authentication: fix a bug where auxiliary tenants were not correctly authorized ([#24063](hashicorp/terraform-provider-azurerm#24063 `azurerm_app_configuration` - normalize location in `replica` block ([#24074](hashicorp/terraform-provider-azurerm#24074 `azurerm_cosmosdb_account` - cosmosdb version and capabilities can now be updated at the same time ([#24029](hashicorp/terraform-provider-azurerm#24029 `azurerm_data_factory_flowlet_data_flow` - `source` and `sink` properties are now optional ([#23987](hashicorp/terraform-provider-azurerm#23987 `azurerm_datadog_monitor_tag_rule` - correctly handle default rule ([#22806](hashicorp/terraform-provider-azurerm#22806 `azurerm_ip_group`: fixing a crash when `firewall_ids` and `firewall_policy_ids` weren't parsed correctly from the API Response ([#24031](hashicorp/terraform-provider-azurerm#24031 `azurerm_nginx_deployment` - add default value of `20` for `capacity` ([#24033](https://github.com/hashicorp/terraform-provider-azurerm/issues/24033))


</pre> </details> <details> <summary>3.84.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.84.0
FEATURES:

* **New Data Source:** `azurerm_storage_containers` ([#24061](hashicorp/terraform-provider-azurerm#24061 **New Resource:** `azurerm_elastic_san` ([#23619](hashicorp/terraform-provider-azurerm#23619 **New Resource:** `azurerm_key_vault_managed_hardware_security_module_role_assignment` ([#22332](hashicorp/terraform-provider-azurerm#22332 **New Resource:** `azurerm_key_vault_managed_hardware_security_module_role_definition` ([#22332](https://github.com/hashicorp/terraform-provider-azurerm/issues/22332))

ENHANCEMENTS:

* dependencies: updating mssql elasticpools from `v5.0` to `2023-05-01-preview`
* dependencies: updating to `v0.20231207.1122031` of `github.com/hashicorp/go-azure-sdk` ([#24149](hashicorp/terraform-provider-azurerm#24149 Data Source: `azurerm_storage_account` - export the primary and secondary internet and microsoft hostnames for blobs, dfs, files, queues, tables and web ([#23517](hashicorp/terraform-provider-azurerm#23517 Data Source: `azurerm_cosmosdb_account` - export the `connection_strings`, `primary_sql_connection_string`, `secondary_sql_connection_string`, `primary_readonly_sql_connection_string`, `secondary_readonly_sql_connection_string`, `primary_mongodb_connection_string`, `secondary_mongodb_connection_string`, `primary_readonly_mongodb_connection_string`, and `secondary_readonly_mongodb_connection_string` attributes ([#24129](hashicorp/terraform-provider-azurerm#24129 `azurerm_bot_service_azure_bot` - support for the `public_network_access_enabled` property ([#24125](hashicorp/terraform-provider-azurerm#24125 `azurerm_container_app_environment` - support for the `workload_profile` property ([#23478](hashicorp/terraform-provider-azurerm#23478 `azurerm_cosmosdb_cassandra_datacenter` - support for the `seed_node_ip_addresses` property ([#24076](hashicorp/terraform-provider-azurerm#24076 `azurerm_firewall` - support for the `dns_proxy_enabled` property ([#20519](hashicorp/terraform-provider-azurerm#20519 `azurerm_kubernetes_cluster` - support for the `support_plan` property and the `sku_tier` `Premium` ([#23970](hashicorp/terraform-provider-azurerm#23970 `azurerm_mssql_database` - support for `enclave_type` field ([#24054](hashicorp/terraform-provider-azurerm#24054 `azurerm_mssql_elasticpool` - support for `enclave_type` field ([#24054](hashicorp/terraform-provider-azurerm#24054 `azurerm_mssql_managed_instance` - support for more `vcores`: `6`, `10`, `12`, `20`, `48`, `56`, `96`, `128` ([#24085](hashicorp/terraform-provider-azurerm#24085 `azurerm_redis_linked_server` - support for the property `geo_replicated_primary_host_name` ([#23984](hashicorp/terraform-provider-azurerm#23984 `azurerm_storage_account` - expose the primary and secondary internet and microsoft hostnames for blobs, dfs, files, queues, tables and web ([#23517](hashicorp/terraform-provider-azurerm#23517 `azurerm_synapse_role_assignment` - support for the `principal_type` property ([#24089](hashicorp/terraform-provider-azurerm#24089 `azurerm_spring_cloud_build_deployment` - support for the `application_performance_monitoring_ids` property ([#23969](hashicorp/terraform-provider-azurerm#23969 `azurerm_virtual_network_gateway` - support for the `bgp_route_translation_for_nat_enabled`, `dns_forwarding_enabled`, `ip_sec_replay_protection_enabled`, `remote_vnet_traffic_enabled`, `virtual_wan_traffic_enabled`, `radius_server`, `virtual_network_gateway_client_connection`, `policy_group`, and `ipsec_policy` property ([#23220](https://github.com/hashicorp/terraform-provider-azurerm/issues/23220))

BUG FIXES:

* `azurerm_application_insights_api_key` - prevent a bug where multiple keys couldn't be created for an Application Insights instance ([#23463](hashicorp/terraform-provider-azurerm#23463 `azurerm_container_registry` - the `network_rule_set.virtual_network` property has been deprecated ([#24140](hashicorp/terraform-provider-azurerm#24140 `azurerm_hdinsight_hadoop_cluster` - set `roles.edge_node.install_script_action.parameters` into state by retrieving the value provided in the user config since this property isn't returned by the API ([#23971](hashicorp/terraform-provider-azurerm#23971 `azurerm_kubernetes_cluster` - prevent a bug where maintenance window start date was always recalculated and sent to the API ([#23985](hashicorp/terraform-provider-azurerm#23985 `azurerm_mssql_database` - will no longer send all long retention values in payload unless set ([#24124](hashicorp/terraform-provider-azurerm#24124 `azurerm_mssql_managed_database` - will no longer send all long retention values in payload unless set ([#24124](hashicorp/terraform-provider-azurerm#24124 `azurerm_mssql_server_microsoft_support_auditing_policy` - only include storage endpoint in payload if set ([#24122](hashicorp/terraform-provider-azurerm#24122 `azurerm_mobile_network_packet_core_control_plane` - prevent a panic if the HTTP Response is nil ([#24083](hashicorp/terraform-provider-azurerm#24083 `azurerm_storage_account` - revert plan time name validation `(#23799)` ([#24142](hashicorp/terraform-provider-azurerm#24142 `azurerm_web_application_firewall_policy` - split create and update function to fix lifecycle - ignore changes ([#23412](https://github.com/hashicorp/terraform-provider-azurerm/issues/23412))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/931/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]> Co-authored-by: Damien Duportal <[email protected]>

github-actions · 2024-05-05T02:10:40Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 3 commits September 7, 2023 17:14

azurerm_virtual_network_gateway - support for the missed properties

fd592f6

update code

113ae85

update code

a0e2868

github-actions bot added documentation service/network size/L waiting-response labels Sep 8, 2023

update code

ce6fd0f

github-actions bot removed the waiting-response label Sep 8, 2023

neil-yechenwei added 2 commits September 11, 2023 07:59

update code

c117ac5

update code

7bb9aa1

katbyte approved these changes Sep 26, 2023

View reviewed changes

neil-yechenwei added 2 commits October 9, 2023 09:09

Merge remote-tracking branch 'upstream/main' into vnetgw04

870bf15

update code

b6ee0ad

github-actions bot added size/XL and removed size/L labels Oct 9, 2023

update code

8646077

github-actions bot added the waiting-response label Oct 9, 2023

update code

ec7c0eb

github-actions bot removed the waiting-response label Oct 9, 2023

neil-yechenwei added 2 commits October 10, 2023 08:44

update code

14028fd

update code

0485462

neil-yechenwei added 3 commits October 10, 2023 14:58

update code

c7a5d7d

update code

8aae17d

update code

8234233

github-actions bot added the waiting-response label Oct 12, 2023

Merge remote-tracking branch 'upstream/main' into vnetgw04

5c5fa25

github-actions bot removed the waiting-response label Oct 12, 2023

manicminer added the enhancement label Oct 12, 2023

manicminer added the waiting-response label Oct 12, 2023

Merge remote-tracking branch 'upstream/main' into vnetgw04

e30f7d9

github-actions bot removed the waiting-response label Oct 13, 2023

update code

16b2392

update code

caaa94c

katbyte requested changes Nov 7, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 7, 2023

github-actions bot removed the waiting-response label Nov 7, 2023

neil-yechenwei requested a review from katbyte November 7, 2023 05:34

manicminer self-assigned this Nov 20, 2023

katbyte approved these changes Dec 5, 2023

View reviewed changes

katbyte merged commit f354f4d into hashicorp:main Dec 6, 2023
26 checks passed

github-actions bot added this to the v3.84.0 milestone Dec 6, 2023

katbyte added a commit that referenced this pull request Dec 6, 2023

Update CHANGELOG.md #23220

09e6d1e

This was referenced Dec 9, 2023

InfraPatch Module and Provider Update Noahnc/infrapatch#45

Closed

InfraPatch Module and Provider Update Noahnc/infrapatch#46

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_virtual_network_gateway` - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

`azurerm_virtual_network_gateway` - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

neil-yechenwei commented Sep 8, 2023 •

edited

Loading

katbyte left a comment

manicminer commented Oct 12, 2023

neil-yechenwei commented Oct 14, 2023

katbyte left a comment

katbyte left a comment

katbyte left a comment

neil-yechenwei commented Nov 7, 2023 •

edited

Loading

katbyte left a comment

neil-yechenwei commented Dec 6, 2023

github-actions bot commented May 5, 2024

azurerm_virtual_network_gateway - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

azurerm_virtual_network_gateway - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

Conversation

neil-yechenwei commented Sep 8, 2023 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

manicminer commented Oct 12, 2023

neil-yechenwei commented Oct 14, 2023

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Nov 7, 2023 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Dec 6, 2023

github-actions bot commented May 5, 2024

`azurerm_virtual_network_gateway` - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

`azurerm_virtual_network_gateway` - support for `bgp_route_translation_for_nat_enabled, dns_forwarding_enabled, ip_sec_replay_protection_enabled, remote_vnet_traffic_enabled, virtual_wan_traffic_enabled, radius_server, virtual_network_gateway_client_connection, policy_group and ipsec_policy #23220

neil-yechenwei commented Sep 8, 2023 •

edited

Loading

neil-yechenwei commented Nov 7, 2023 •

edited

Loading