New Data Source: `azurerm_storage_containers` #24061

magodo · 2023-11-29T09:12:57Z

Test

terraform-provider-azurerm on  storage_container_ds_containers via 🐹 v1.21.4
💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccDataSourcestorageContainers_'
=== RUN   TestAccDataSourcestorageContainers_basic
=== PAUSE TestAccDataSourcestorageContainers_basic
=== RUN   TestAccDataSourcestorageContainers_prefix
=== PAUSE TestAccDataSourcestorageContainers_prefix
=== CONT  TestAccDataSourcestorageContainers_basic
=== CONT  TestAccDataSourcestorageContainers_prefix
--- PASS: TestAccDataSourcestorageContainers_prefix (162.67s)
--- PASS: TestAccDataSourcestorageContainers_basic (163.37s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       163.387s

tombuildsstuff · 2023-11-29T15:58:53Z

@magodo rather than adding this into the azurerm_storage_account resource - this is probably a good candidate for a plural azurerm_storage_containers data source - which would then allow us to support filtering options on this in the future - for example:

data "azurerm_storager_containers" "sources" {
  storage_account_id = "..."
  name_prefix = "example-*"

  # exporting
  #containers {
  #  name = ""
  #  data_plane_id = ""
  #  resource_manager_id = ""
  #}
}

In addition since both the Data Plane and Resource Manager IDs are useful depending on the output, I think it'd probably be prudent to export both?

An aside, but I think worth mentioning: I'm unsure how useful these'd be in the short-term - longer-term the ListCompleteMatchingPredicate functions are intended to make these "plural" data sources easier to build (particularly in an automated fashion), so using a "plural" data source would align with that.

…er` blocks" This reverts commit 8e5a41e.

magodo · 2023-11-30T10:01:36Z

@tombuildsstuff I've reverted the previous change and created the new data source per your comment, please take another look!

tombuildsstuff

A few minor comments but this otherwise LGTM 👍

tombuildsstuff · 2023-12-01T10:04:14Z

internal/services/storage/storage_containers_data_source.go

+			}
+
+			// Ignore the error as is guaranteed by the schema
+			id, _ := commonids.ParseStorageAccountID(plan.StorageAccountId)


Can we always raise these regardless? There's been instances where a merge conflict has unintentionally removed validation checks - so this is a good safety net

Suggested change

id, _ := commonids.ParseStorageAccountID(plan.StorageAccountId)

id, err := commonids.ParseStorageAccountID(plan.StorageAccountId)

if err != nil {

return err

}

tombuildsstuff · 2023-12-01T10:04:47Z

internal/services/storage/storage_containers_data_source_test.go

+
+type storageContainersDataSource struct{}
+
+func TestAccDataSourcestorageContainers_basic(t *testing.T) {


nit

Suggested change

func TestAccDataSourcestorageContainers_basic(t *testing.T) {

func TestAccDataSourceStorageContainers_basic(t *testing.T) {

tombuildsstuff · 2023-12-01T10:04:55Z

internal/services/storage/storage_containers_data_source_test.go

+	})
+}
+
+func TestAccDataSourcestorageContainers_prefix(t *testing.T) {


Suggested change

func TestAccDataSourcestorageContainers_prefix(t *testing.T) {

func TestAccDataSourceStorageContainers_prefix(t *testing.T) {

tombuildsstuff · 2023-12-01T10:08:31Z

website/docs/d/storage_containers.html.markdown

+
+---
+
+* `name_prefix` - (Optional) A prefix match used for the Storage Container `name` field, case sensitive.


Terraform is case-sensitive by default (like most systems are), so I don't think we need to call this one out explicitly?

Suggested change

* `name_prefix` - (Optional) A prefix match used for the Storage Container `name` field, case sensitive.

* `name_prefix` - (Optional) A prefix match used for the Storage Container `name` field.

tombuildsstuff · 2023-12-01T10:09:41Z

website/docs/d/storage_containers.html.markdown

+
+# Data Source: azurerm_storage_containers
+
+Use this data source to access information about an existing Storage Containers.


Suggested change

Use this data source to access information about an existing Storage Containers.

Use this data source to access information about the Storage Containers available within a Storage Account.

magodo · 2023-12-04T02:20:01Z

@tombuildsstuff Thank you for the review! I've resolved all the comments, please take another look!

stephybun

Test looks good, thanks @magodo. LGTM 👍

…4061 #23971 #24083

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.82.0" to "3.83.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.83.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.83.0
UPGRADE NOTES

* Key Vaults are now loaded using [the `ListBySubscription` API within the Key Vault Resource Provider](https://learn.microsoft.com/en-us/rest/api/keyvault/keyvault/vaults/list-by-subscription?view=rest-keyvault-keyvault-2022-07-01&tabs=HTTP) rather than [the Resources API](https://learn.microsoft.com/en-us/rest/api/keyvault/keyvault/vaults/list?view=rest-keyvault-keyvault-2022-07-01&tabs=HTTP). This change means that the Provider now caches the list of Key Vaults available within a Subscription, rather than loading these piecemeal to workaround stale data returned from the Resources API ([#24019](https://github.com/hashicorp/terraform-provider-azurerm/issues/24019))

FEATURES:

* New Data Source: `azurerm_stack_hci_cluster` ([#24032](https://github.com/hashicorp/terraform-provider-azurerm/issues/24032))

ENHANCEMENTS:

* dependencies: updating to `v0.20231129.1103252` of `github.com/hashicorp/go-azure-sdk` ([#24063](hashicorp/terraform-provider-azurerm#24063 `automation`: updating to API Version `2023-11-01` ([#24017](hashicorp/terraform-provider-azurerm#24017 `keyvault`: the cache is now populated using the `ListBySubscription` endpoint on the KeyVault Resource Provider rather than via the `Resources` API ([#24019](hashicorp/terraform-provider-azurerm#24019 `keyvault`: updating the cache to populate all Key Vaults available within the Subscription to reduce the number of API calls ([#24019](hashicorp/terraform-provider-azurerm#24019 Data Source `azurerm_private_dns_zone`: refactoring to use the `ListBySubscription` API rather than the Resources API when `resource_group_name` is omitted ([#24024](hashicorp/terraform-provider-azurerm#24024 `azurerm_dashboard_grafana` - support for `grafana_major_version` ([#24014](hashicorp/terraform-provider-azurerm#24014 `azurerm_linux_web_app` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_linux_web_app_slot` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_media_transform` - deprecate `face_detector_preset` and `video_analyzer_preset` ([#24002](hashicorp/terraform-provider-azurerm#24002 `azurerm_postgresql_database` - update the validation of `collation` to include `Norwegian_Norway.1252` ([#24070](hashicorp/terraform-provider-azurerm#24070 `azurerm_postgresql_flexible_server` - updating to API Version `2023-06-01-preview` ([#24016](hashicorp/terraform-provider-azurerm#24016 `azurerm_redis_cache` - support for the `active_directory_authentication_enabled` property ([#23976](hashicorp/terraform-provider-azurerm#23976 `azurerm_windows_web_app` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_windows_web_app_slot` - add support for dotnet 8 ([#23893](hashicorp/terraform-provider-azurerm#23893 `azurerm_storage_account` - add `name` validation in custom diff ([#23799](https://github.com/hashicorp/terraform-provider-azurerm/issues/23799))

BUG FIXES:

* authentication: fix a bug where auxiliary tenants were not correctly authorized ([#24063](hashicorp/terraform-provider-azurerm#24063 `azurerm_app_configuration` - normalize location in `replica` block ([#24074](hashicorp/terraform-provider-azurerm#24074 `azurerm_cosmosdb_account` - cosmosdb version and capabilities can now be updated at the same time ([#24029](hashicorp/terraform-provider-azurerm#24029 `azurerm_data_factory_flowlet_data_flow` - `source` and `sink` properties are now optional ([#23987](hashicorp/terraform-provider-azurerm#23987 `azurerm_datadog_monitor_tag_rule` - correctly handle default rule ([#22806](hashicorp/terraform-provider-azurerm#22806 `azurerm_ip_group`: fixing a crash when `firewall_ids` and `firewall_policy_ids` weren't parsed correctly from the API Response ([#24031](hashicorp/terraform-provider-azurerm#24031 `azurerm_nginx_deployment` - add default value of `20` for `capacity` ([#24033](https://github.com/hashicorp/terraform-provider-azurerm/issues/24033))


</pre> </details> <details> <summary>3.84.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.84.0
FEATURES:

* **New Data Source:** `azurerm_storage_containers` ([#24061](hashicorp/terraform-provider-azurerm#24061 **New Resource:** `azurerm_elastic_san` ([#23619](hashicorp/terraform-provider-azurerm#23619 **New Resource:** `azurerm_key_vault_managed_hardware_security_module_role_assignment` ([#22332](hashicorp/terraform-provider-azurerm#22332 **New Resource:** `azurerm_key_vault_managed_hardware_security_module_role_definition` ([#22332](https://github.com/hashicorp/terraform-provider-azurerm/issues/22332))

ENHANCEMENTS:

* dependencies: updating mssql elasticpools from `v5.0` to `2023-05-01-preview`
* dependencies: updating to `v0.20231207.1122031` of `github.com/hashicorp/go-azure-sdk` ([#24149](hashicorp/terraform-provider-azurerm#24149 Data Source: `azurerm_storage_account` - export the primary and secondary internet and microsoft hostnames for blobs, dfs, files, queues, tables and web ([#23517](hashicorp/terraform-provider-azurerm#23517 Data Source: `azurerm_cosmosdb_account` - export the `connection_strings`, `primary_sql_connection_string`, `secondary_sql_connection_string`, `primary_readonly_sql_connection_string`, `secondary_readonly_sql_connection_string`, `primary_mongodb_connection_string`, `secondary_mongodb_connection_string`, `primary_readonly_mongodb_connection_string`, and `secondary_readonly_mongodb_connection_string` attributes ([#24129](hashicorp/terraform-provider-azurerm#24129 `azurerm_bot_service_azure_bot` - support for the `public_network_access_enabled` property ([#24125](hashicorp/terraform-provider-azurerm#24125 `azurerm_container_app_environment` - support for the `workload_profile` property ([#23478](hashicorp/terraform-provider-azurerm#23478 `azurerm_cosmosdb_cassandra_datacenter` - support for the `seed_node_ip_addresses` property ([#24076](hashicorp/terraform-provider-azurerm#24076 `azurerm_firewall` - support for the `dns_proxy_enabled` property ([#20519](hashicorp/terraform-provider-azurerm#20519 `azurerm_kubernetes_cluster` - support for the `support_plan` property and the `sku_tier` `Premium` ([#23970](hashicorp/terraform-provider-azurerm#23970 `azurerm_mssql_database` - support for `enclave_type` field ([#24054](hashicorp/terraform-provider-azurerm#24054 `azurerm_mssql_elasticpool` - support for `enclave_type` field ([#24054](hashicorp/terraform-provider-azurerm#24054 `azurerm_mssql_managed_instance` - support for more `vcores`: `6`, `10`, `12`, `20`, `48`, `56`, `96`, `128` ([#24085](hashicorp/terraform-provider-azurerm#24085 `azurerm_redis_linked_server` - support for the property `geo_replicated_primary_host_name` ([#23984](hashicorp/terraform-provider-azurerm#23984 `azurerm_storage_account` - expose the primary and secondary internet and microsoft hostnames for blobs, dfs, files, queues, tables and web ([#23517](hashicorp/terraform-provider-azurerm#23517 `azurerm_synapse_role_assignment` - support for the `principal_type` property ([#24089](hashicorp/terraform-provider-azurerm#24089 `azurerm_spring_cloud_build_deployment` - support for the `application_performance_monitoring_ids` property ([#23969](hashicorp/terraform-provider-azurerm#23969 `azurerm_virtual_network_gateway` - support for the `bgp_route_translation_for_nat_enabled`, `dns_forwarding_enabled`, `ip_sec_replay_protection_enabled`, `remote_vnet_traffic_enabled`, `virtual_wan_traffic_enabled`, `radius_server`, `virtual_network_gateway_client_connection`, `policy_group`, and `ipsec_policy` property ([#23220](https://github.com/hashicorp/terraform-provider-azurerm/issues/23220))

BUG FIXES:

* `azurerm_application_insights_api_key` - prevent a bug where multiple keys couldn't be created for an Application Insights instance ([#23463](hashicorp/terraform-provider-azurerm#23463 `azurerm_container_registry` - the `network_rule_set.virtual_network` property has been deprecated ([#24140](hashicorp/terraform-provider-azurerm#24140 `azurerm_hdinsight_hadoop_cluster` - set `roles.edge_node.install_script_action.parameters` into state by retrieving the value provided in the user config since this property isn't returned by the API ([#23971](hashicorp/terraform-provider-azurerm#23971 `azurerm_kubernetes_cluster` - prevent a bug where maintenance window start date was always recalculated and sent to the API ([#23985](hashicorp/terraform-provider-azurerm#23985 `azurerm_mssql_database` - will no longer send all long retention values in payload unless set ([#24124](hashicorp/terraform-provider-azurerm#24124 `azurerm_mssql_managed_database` - will no longer send all long retention values in payload unless set ([#24124](hashicorp/terraform-provider-azurerm#24124 `azurerm_mssql_server_microsoft_support_auditing_policy` - only include storage endpoint in payload if set ([#24122](hashicorp/terraform-provider-azurerm#24122 `azurerm_mobile_network_packet_core_control_plane` - prevent a panic if the HTTP Response is nil ([#24083](hashicorp/terraform-provider-azurerm#24083 `azurerm_storage_account` - revert plan time name validation `(#23799)` ([#24142](hashicorp/terraform-provider-azurerm#24142 `azurerm_web_application_firewall_policy` - split create and update function to fix lifecycle - ignore changes ([#23412](https://github.com/hashicorp/terraform-provider-azurerm/issues/23412))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/931/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]> Co-authored-by: Damien Duportal <[email protected]>

github-actions · 2024-05-05T02:10:52Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Data Source: azurerm_storage_account - Support the container blocks

8e5a41e

magodo added enhancement service/storage labels Nov 29, 2023

github-actions bot added documentation size/M labels Nov 29, 2023

rcskosir mentioned this pull request Nov 29, 2023

Support for getting a list of container names in a storage account #24057

Closed

1 task

magodo added 2 commits November 30, 2023 09:37

Revert "Data Source: azurerm_storage_account - Support the `contain…

cba91c8

…er` blocks" This reverts commit 8e5a41e.

New Data Source: azurerm_storage_containers

4d0f1bd

magodo changed the title ~~Data Source: azurerm_storage_account - Support the container blocks~~ New Data Source: azurerm_storage_containers Nov 30, 2023

github-actions bot added size/XL and removed size/M labels Nov 30, 2023

magodo added new-data-source and removed enhancement labels Nov 30, 2023

github-actions bot added the waiting-response label Nov 30, 2023

make generate

84c1c60

github-actions bot removed the waiting-response label Dec 1, 2023

tombuildsstuff approved these changes Dec 1, 2023

View reviewed changes

resolve review comments

3d0eb8b

stephybun approved these changes Dec 4, 2023

View reviewed changes

stephybun merged commit 930fbfa into hashicorp:main Dec 5, 2023
24 checks passed

github-actions bot added this to the v3.84.0 milestone Dec 5, 2023

stephybun added a commit that referenced this pull request Dec 6, 2023

Update for #23619 #23985 #23984 #24076 #23463 #23517 #24085 #23970 #2…

578094e

…4061 #23971 #24083

This was referenced Dec 9, 2023

InfraPatch Module and Provider Update Noahnc/infrapatch#45

Closed

InfraPatch Module and Provider Update Noahnc/infrapatch#46

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Data Source: `azurerm_storage_containers` #24061

New Data Source: `azurerm_storage_containers` #24061

magodo commented Nov 29, 2023 •

edited

Loading

tombuildsstuff commented Nov 29, 2023

magodo commented Nov 30, 2023

tombuildsstuff left a comment

tombuildsstuff Dec 1, 2023

tombuildsstuff Dec 1, 2023

tombuildsstuff Dec 1, 2023

tombuildsstuff Dec 1, 2023

tombuildsstuff Dec 1, 2023

magodo commented Dec 4, 2023

stephybun left a comment

github-actions bot commented May 5, 2024

-			id, _ := commonids.ParseStorageAccountID(plan.StorageAccountId)
+			id, err := commonids.ParseStorageAccountID(plan.StorageAccountId)
+			if err != nil {
+				return err
+			}


		type storageContainersDataSource struct{}

		func TestAccDataSourcestorageContainers_basic(t *testing.T) {


		---

		* `name_prefix` - (Optional) A prefix match used for the Storage Container `name` field, case sensitive.


		# Data Source: azurerm_storage_containers

		Use this data source to access information about an existing Storage Containers.

New Data Source: azurerm_storage_containers #24061

New Data Source: azurerm_storage_containers #24061

Conversation

magodo commented Nov 29, 2023 • edited Loading

Test

tombuildsstuff commented Nov 29, 2023

magodo commented Nov 30, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Dec 1, 2023

Choose a reason for hiding this comment

tombuildsstuff Dec 1, 2023

Choose a reason for hiding this comment

tombuildsstuff Dec 1, 2023

Choose a reason for hiding this comment

tombuildsstuff Dec 1, 2023

Choose a reason for hiding this comment

tombuildsstuff Dec 1, 2023

Choose a reason for hiding this comment

magodo commented Dec 4, 2023

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented May 5, 2024

New Data Source: `azurerm_storage_containers` #24061

New Data Source: `azurerm_storage_containers` #24061

magodo commented Nov 29, 2023 •

edited

Loading