Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection - add StateRefreshFunc for SetSharedKey API #23860

Merged
merged 11 commits into from
Nov 24, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Nov 10, 2023

TestAccVirtualNetworkGatewayConnection_updatingSharedKey is failed in Teamcity for a long time. So I did some investigation for it.

Finding 1:
For the update testing, TestAccVirtualNetworkGatewayConnection_updatingSharedKey triggers unexpected force replacement. So I updated the parameters in test case to not trigger force replacement.

Finding 2:
While calling setSharedKey API, though statusCode is "200" but the provisioningState is "Updating". So I added the StateRefreshFunc.

image
image

@github-actions github-actions bot added size/S and removed size/XS labels Nov 10, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏳

@katbyte katbyte merged commit e3c013b into hashicorp:main Nov 24, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.82.0 milestone Nov 24, 2023
Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants