-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_network_gateway_connection
- add StateRefreshFunc
for SetSharedKey API
#23860
Conversation
azurerm_virtual_network_gateway_connection
- add lock
for delete
operationazurerm_virtual_network_gateway_connection
- add StateRefreshFunc
for SetSharedKey API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⏳
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
TestAccVirtualNetworkGatewayConnection_updatingSharedKey is failed in Teamcity for a long time. So I did some investigation for it.
Finding 1:
For the update testing, TestAccVirtualNetworkGatewayConnection_updatingSharedKey triggers unexpected force replacement. So I updated the parameters in test case to not trigger force replacement.
Finding 2:
While calling setSharedKey API, though statusCode is "200" but the provisioningState is "Updating". So I added the StateRefreshFunc.