Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Azure Virtual WAN and child resources #3279

Closed
Jandakast opened this issue Apr 18, 2019 · 20 comments
Closed

Feature Request: Support for Azure Virtual WAN and child resources #3279

Jandakast opened this issue Apr 18, 2019 · 20 comments

Comments

@Jandakast
Copy link

Jandakast commented Apr 18, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Support for Azure Virtual WAN and child resources

Looking for the ability to deploy and manage Azure Virtual WAN resources with Terraform.

  • azurerm_virtual_wan now available
  • azurerm_virtual_wan_hub
  • azurerm_virtual_wan_site_to_site_vpn
  • azurerm_virtual_wan_expressroute_circuits (Currently in Preview)

References

https://docs.microsoft.com/en-us/azure/virtual-wan/
https://docs.microsoft.com/en-us/azure/templates/microsoft.network/2018-11-01/virtualwans
https://docs.microsoft.com/en-us/azure/templates/microsoft.network/2018-11-01/virtualhubs
https://docs.microsoft.com/en-us/azure/templates/microsoft.network/2018-11-01/vpnsites

@joakimhellum
Copy link

Hi, we need this in the organization ASAP so we started working on some of the resources for Azure Virtual WAN, such as: azurerm_virtual_wan, azurerm_virtual_hub, azurerm_vpn_gateway, azurerm_vpn_gateway_connection, azurerm_p2s_vpn_gateway, azurerm_express_route_gateway, azurerm_virtual_hub_route_table, azurerm_virtual_hub_network_connection. We hope to make PR ready for review early next week.

@ghost
Copy link

ghost commented Jun 4, 2019

Hi @joakimhellum-in , have you made any traction here?

@venkybems
Copy link

@joakimhellum-in - Any update on the virtual-wan resources?

@mybayern1974
Copy link
Collaborator

An update for azurerm_p2s_vpn_gateway that this resource is not functionality ready yet though it's in the preview stage now. The rough estimated date when it could work is going to be around Sep 20, 2019

@skalragg
Copy link

Apologies if I should be posting this somewhere else, any timeline on the virtual WAN child functions. eg. building a site to site VPN after resource azurerm_vpn_gateway has been attached to a virtual hub

I can see PR like where it looks like some of this functionality was removed #5004

I would be really grateful if the vwan and child resources were expanded. Thanks

@tombuildsstuff
Copy link
Contributor

@skalragg unfortunately the Azure API is broken, so the connections functionality ended up having to be removed; however the resource development is mostly done - so once the API's in a good state we can look to reintroduce it; but at the moment we're waiting on the Networking team

Thanks!

@skalragg
Copy link

@skalragg unfortunately the Azure API is broken, so the connections functionality ended up having to be removed; however the resource development is mostly done - so once the API's in a good state we can look to reintroduce it; but at the moment we're waiting on the Networking team

Thanks!

@tombuildsstuff Thanks for the quick response! is this the best thread #3279 to keep checking for updates, or should I be looking elsewhere? Thanks

@tombuildsstuff
Copy link
Contributor

@skalragg for now, I'd suggest subscribing to this issue as the best place to ask, since we can run the tests to confirm this has been fixed

@skalragg
Copy link

skalragg commented Jan 30, 2020

@skalragg for now, I'd suggest subscribing to this issue as the best place to ask, since we can run the tests to confirm this has been fixed

Hi @tombuildsstuff
Any feedback from the network team in relation to when this may be resolved. Many thanks

@LaurentLesle
Copy link
Contributor

@tombuildsstuff are you saying it is broken with the version 2019-11-01 of the networking sdk?

@tombuildsstuff
Copy link
Contributor

@LaurentLesle last time we took a look at this (November/December) the API (2019-09-01) was broken so this ended up having to be reverted. The original work can be found in this commit (this is intentionally split-out rather than in-lined) but unfortunately we've not tested 2019-11-01 yet

@skalragg
Copy link

@tombuildsstuff any timeline for retesting / or is there any way to use the previous commit
Thanks

@baljitaujlaVD
Copy link

baljitaujlaVD commented Mar 2, 2020

@tombuildsstuff - Hi Tom, imagine you are super busy but was wondering if there were any updates on Azure Virtual WAN deployments?

Would this also include the ability to create 'Virtual network connections' from the HUB to a different VNet?

Thanks for all your support!

@jturver1
Copy link

jturver1 commented Jun 1, 2020

It would also be great if the VWAN capability will include the "Secure Virtual Hub" Firewall Manager integration for deployment of an embedded (vs. NVA) Azure Firewall into VWAN hubs, and subsequent management of firewall policy via Azure Firewall Manager (currently preview).

This is not GA yet (I'm guessing it will be soon), but it will be a very highly adopted use case vs. traditional VNET hub and spoke models with NVA firewalls going forward.

@petr-stupka
Copy link
Contributor

petr-stupka commented Oct 27, 2020

for 'Azure Firewall Manager' resources see #7319

@cidwtz
Copy link

cidwtz commented Oct 27, 2020

The Azure virtualwans API version is updated to "2020-05-01" with a few new features rolled out include routing table on the hub/connections. Do it still have the bug in API in 2019? I just wonder if it is possible to implement those features now?

@arnaudlh
Copy link

hi, are we tracking the creation of the Express Route Circuit to a Virtual Hub? From the UI, we can connect multiple circuits into the ER attached to the virtual hub, would be nice to support it with TF - cc @LaurentLesle @arnoldna

@neil-yechenwei
Copy link
Contributor

neil-yechenwei commented Nov 19, 2020

@cidwtz , thanks for your comment. I assume all features of VirtualWans API except Express Route Circuit have been implemented in the latest azurerm.

@tombuildsstuff
Copy link
Contributor

👋

Since this is turning into more of an open-ended meta-issue (which'll obviously expand over time as new functionality is added) - I'm going to suggest we close this issue for the moment, since support for the majority of these resources are now supported.

For new functionality going forward, including the Express Route Circuit functionality that @arnaudlh has mentioned above, would you mind opening a new Feature Request including the relevant details so that we can track this in a more granular fashion?

Thanks!

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests