Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_virtual_wan #3505

Closed
wants to merge 4 commits into from
Closed

New resource: azurerm_virtual_wan #3505

wants to merge 4 commits into from

Conversation

joakimhellum
Copy link

Reference to #3279

@venkybems
Copy link

@joakimhellum-in - Could you please let us know when we can expect availability of this support?

@katbyte katbyte marked this pull request as ready for review June 27, 2019 23:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joakimhellum-in,

Aside from a couple small comments this LGTM.

azurerm/resource_arm_virtual_wan.go Show resolved Hide resolved
azurerm/resource_arm_virtual_wan.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joakimhellum-in, looks like i can't push to your branch. Let me know if if you'll make the required changes or i should open a new PR.

@joakimhellum joakimhellum changed the title [WIP] New resource: azurerm_virtual_wan New resource: azurerm_virtual_wan Jul 4, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joakimhellum-in,

You'll need to merge in/rebase off master & fix the build:

[00:34:45]	[Step 2/5] # github.com/terraform-providers/terraform-provider-azurerm/azurerm [github.com/terraform-providers/terraform-provider-azurerm/azurerm.test]
[00:34:45]	[Step 2/5] azurerm/data_source_redis_cache.go:196:29: meta.(*ArmClient).redisClient undefined (type *ArmClient has no field or method redisClient)
[00:34:45]	[Step 2/5] azurerm/data_source_redis_cache.go:247:43: meta.(*ArmClient).redisPatchSchedulesClient undefined (type *ArmClient has no field or method redisPatchSchedulesClient)

@katbyte
Copy link
Collaborator

katbyte commented Aug 2, 2019

👋 @joakimhellum-in

Just wondering if your still working on this or if i should open a new branch & pr to get this in

@joakimhellum
Copy link
Author

@katbyte Very sorry for missing this. It will be fixed within next 24 hours.

@ghost ghost removed the waiting-response label Aug 2, 2019
@katbyte katbyte added this to the v1.33.0 milestone Aug 2, 2019
@katbyte
Copy link
Collaborator

katbyte commented Aug 11, 2019

👋 @joakimhellum-in,

Just wondering if we should taken this on, hopefully going to release 1.33 soon and it would be great to get this into it.

katbyte added a commit that referenced this pull request Aug 14, 2019
@tombuildsstuff
Copy link
Contributor

hey @joakimhellum-in

Thanks for this PR - apologies for the delay here.

Taking a look through it appears that so that we can get this merged @katbyte has pulled these commits plus the requested changes into a new PR (#4089), which has since been merged - as such I'm going to close this PR for the moment since these changes should be available in the next release :)

Thanks!

@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Aug 22, 2019
@venkybems
Copy link

venkybems commented Aug 22, 2019 via email

@ghost
Copy link

ghost commented Sep 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants