-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_virtual_wan
#3505
Conversation
@joakimhellum-in - Could you please let us know when we can expect availability of this support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joakimhellum-in,
Aside from a couple small comments this LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joakimhellum-in, looks like i can't push to your branch. Let me know if if you'll make the required changes or i should open a new PR.
azurerm_virtual_wan
azurerm_virtual_wan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to merge in/rebase off master & fix the build:
[00:34:45] [Step 2/5] # github.com/terraform-providers/terraform-provider-azurerm/azurerm [github.com/terraform-providers/terraform-provider-azurerm/azurerm.test]
[00:34:45] [Step 2/5] azurerm/data_source_redis_cache.go:196:29: meta.(*ArmClient).redisClient undefined (type *ArmClient has no field or method redisClient)
[00:34:45] [Step 2/5] azurerm/data_source_redis_cache.go:247:43: meta.(*ArmClient).redisPatchSchedulesClient undefined (type *ArmClient has no field or method redisPatchSchedulesClient)
Just wondering if your still working on this or if i should open a new branch & pr to get this in |
@katbyte Very sorry for missing this. It will be fixed within next 24 hours. |
Just wondering if we should taken this on, hopefully going to release 1.33 soon and it would be great to get this into it. |
hey @joakimhellum-in Thanks for this PR - apologies for the delay here. Taking a look through it appears that so that we can get this merged @katbyte has pulled these commits plus the requested changes into a new PR (#4089), which has since been merged - as such I'm going to close this PR for the moment since these changes should be available in the next release :) Thanks! |
This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.33.0"
}
# ... other configuration ... |
Hello Terraform-Providers/Terraform-Provider-Azurerm
Thank you for the heads up on the much waited release.
Could you let me know when will be the packages available for upgrade.
Thanks
Venky
…On Thu, Aug 22, 2019 at 4:26 AM hashibot[bot] ***@***.***> wrote:
This has been released in version 1.33.0 of the provider
<https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.33.0/CHANGELOG.md>.
Please see the Terraform documentation on provider versioning
<https://www.terraform.io/docs/configuration/providers.html#provider-versions>
or reach out if you need any assistance upgrading. As an example:
provider "azurerm" {
version = "~> 1.33.0"
}# ... other configuration ...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3505>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFJYT7T5RO2BL4UV5VRYNWLQFZZXHANCNFSM4HO5YNBA>
.
--
Regards,
Venky.
+1 650 252 2838
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Reference to #3279