New Resource & Data Source: azurerm_virtual_hub
#4919
Conversation
There was a problem hiding this comment.
Hey @neil-yechenwei. This PR looks great. There are some additional nil checks we should do and some formatting issues but other than that we're nearly there
azurerm/resource_arm_virtual_hub.go
Outdated
| results := make([]network.HubVirtualNetworkConnection, 0) | ||
|
|
||
| for _, item := range input { | ||
| v := item.(map[string]interface{}) |
There was a problem hiding this comment.
We should confirm that this isn't nil before casting it.
azurerm/resource_arm_virtual_hub.go
Outdated
|
|
||
| results := make([]network.VirtualHubRoute, 0) | ||
| for _, item := range input { | ||
| v := item.(map[string]interface{}) |
There was a problem hiding this comment.
We should check that this isn't nil before casting it
azurerm/resource_arm_virtual_hub.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringMatch( |
There was a problem hiding this comment.
It looks like this validation is the same as the one in the datasource? Can we pull it out and into it's own separate method to better help maintainer-ship in case it ever changes or needs to be used in other resources?
mbfrahry
changed the title
azurerm_virtual_hub
|
@mbfrahry , Thanks for your comments. I've updated code per you comments. |
|
Thanks for this @neil-yechenwei. We should get this into the next release |
|
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR is code implement for issue #3279